Skip to content

Conversation

@hantmac
Copy link
Contributor

@hantmac hantmac commented Feb 20, 2025

MINIO_ENABLED param will enable minio service in databend which provide object store , more details in this doc: https://hub.docker.com/r/datafuselabs/databend

@hantmac hantmac requested a review from a team February 20, 2025 09:21
@eddumelendez
Copy link
Member

Hi @hantmac, thanks for your contribution. I don't think not much change by just using withEnv("MINIO_ENABLED", "true"). We don't use to map every single env var unless there is a specific logic to execute when the env var is declared.

@hantmac
Copy link
Contributor Author

hantmac commented Feb 22, 2025

Hi @hantmac, thanks for your contribution. I don't think not much change by just using withEnv("MINIO_ENABLED", "true"). We don't use to map every single env var unless there is a specific logic to execute when the env var is declared.
@eddumelendez
For databend docker start server, only minio_enabled will databend use object store or will use file system as storage. But there some tests which written in databend-jdbc need enable object store.

You mean there is no need to add MINIO_ENABLED env here ?

@eddumelendez
Copy link
Member

Yes, there is no need. Thanks for your contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants