From 0de03e5cb3df502711dce2f98bb82cebb4245c2f Mon Sep 17 00:00:00 2001 From: Julian Ladisch Date: Sun, 18 May 2025 22:38:58 +0200 Subject: [PATCH] Show new syntax of KafkaContainer#withListener The withListener method of the deprecated KafkaContainer takes `Supplier`, whereas the withListener method of the current KafkaContainer takes a `String`. Show the new syntax in the documentation. --- docs/modules/kafka.md | 2 +- .../java/org/testcontainers/containers/KafkaContainerTest.java | 2 -- .../test/java/org/testcontainers/kafka/KafkaContainerTest.java | 2 ++ 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/docs/modules/kafka.md b/docs/modules/kafka.md index 6e33cc76b2d..cd2a660c8e0 100644 --- a/docs/modules/kafka.md +++ b/docs/modules/kafka.md @@ -85,7 +85,7 @@ There are scenarios where additional listeners are needed because the consumer/p container in the same network or a different process where the port to connect differs from the default exposed port. E.g [Toxiproxy](../../modules/toxiproxy/). -[Register additional listener](../../modules/kafka/src/test/java/org/testcontainers/containers/KafkaContainerTest.java) inside_block:registerListener +[Register additional listener](../../modules/kafka/src/test/java/org/testcontainers/kafka/KafkaContainerTest.java) inside_block:registerListener Container defined in the same network: diff --git a/modules/kafka/src/test/java/org/testcontainers/containers/KafkaContainerTest.java b/modules/kafka/src/test/java/org/testcontainers/containers/KafkaContainerTest.java index f2a86020701..49b21108da8 100644 --- a/modules/kafka/src/test/java/org/testcontainers/containers/KafkaContainerTest.java +++ b/modules/kafka/src/test/java/org/testcontainers/containers/KafkaContainerTest.java @@ -189,11 +189,9 @@ public void testKraftPrecedenceOverEmbeddedZookeeper() throws Exception { public void testUsageWithListener() throws Exception { try ( Network network = Network.newNetwork(); - // registerListener { KafkaContainer kafka = new KafkaContainer(KAFKA_KRAFT_TEST_IMAGE) .withListener(() -> "kafka:19092") .withNetwork(network); - // } // createKCatContainer { GenericContainer kcat = new GenericContainer<>("confluentinc/cp-kcat:7.9.0") .withCreateContainerCmdModifier(cmd -> { diff --git a/modules/kafka/src/test/java/org/testcontainers/kafka/KafkaContainerTest.java b/modules/kafka/src/test/java/org/testcontainers/kafka/KafkaContainerTest.java index b1764d3b522..e81b52574ef 100644 --- a/modules/kafka/src/test/java/org/testcontainers/kafka/KafkaContainerTest.java +++ b/modules/kafka/src/test/java/org/testcontainers/kafka/KafkaContainerTest.java @@ -25,9 +25,11 @@ public void testUsage() throws Exception { public void testUsageWithListener() throws Exception { try ( Network network = Network.newNetwork(); + // registerListener { KafkaContainer kafka = new KafkaContainer("apache/kafka-native:3.8.0") .withListener("kafka:19092") .withNetwork(network); + // } KCatContainer kcat = new KCatContainer().withNetwork(network) ) { kafka.start();