- 
          
- 
                Notifications
    You must be signed in to change notification settings 
- Fork 1.8k
Fix resource leak in performQuery by using Consumer pattern #11100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Open
      
      
            rajucomp
  wants to merge
  14
  commits into
  testcontainers:main
  
    
      
        
          
  
    
      Choose a base branch
      
     
    
      
        
      
      
        
          
          
        
        
          
            
              
              
              
  
           
        
        
          
            
              
              
           
        
       
     
  
        
          
            
          
            
          
        
       
    
      
from
rajucomp:main
  
      
      
   
  
    
  
  
  
 
  
      
    base: main
Could not load branches
            
              
  
    Branch not found: {{ refName }}
  
            
                
      Loading
              
            Could not load tags
            
            
              Nothing to show
            
              
  
            
                
      Loading
              
            Are you sure you want to change the base?
            Some commits from the old base branch may be removed from the timeline,
            and old review comments may become outdated.
          
          
      
        
          +290
        
        
          −262
        
        
          
        
      
    
  
Conversation
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
    - Changed performQuery method signature from returning ResultSet to accepting Consumer<ResultSet> - Implemented proper resource management with try-with-resources for Connection, Statement, and ResultSet - Updated all test files across database modules to use new lambda-based pattern - Wrapped assertions in assertThatNoException().isThrownBy() blocks for proper exception handling This change ensures JDBC resources are properly closed after query execution, preventing resource leaks. Note: Additional resource leak fixes will follow in subsequent PRs. This PR focuses on the performQuery enhancement to facilitate easier review.
…od for consistency
…ry to accept expected values for assertions
…cuteQuery for consistency
…cuteQuery for consistency
| @eddumelendez Let me know if this is worthy of a review. Thanks! | 
  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment
  
      
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
PR Summary: Fix Resource Leak in performQuery Method
Overview
This PR addresses resource leaks in the
performQuerymethod by implementing proper JDBC resource management using the Consumer pattern.Changes Made
Core Enhancement:
AbstractContainerDatabaseTest.performQuery()method signature:protected ResultSet performQuery(JdbcDatabaseContainer<?> container, String sql) throws SQLExceptionprotected void performQuery(JdbcDatabaseContainer<?> container, String sql, Consumer<ResultSet> consumer) throws SQLExceptionTest Updates (20 files):
Updated all database module tests to use the new lambda-based pattern:
Pattern Applied:
Impact
Note
This PR is scoped to the
performQueryenhancement only to facilitate easier review. Additional resource leak fixes across the codebase will follow in subsequent PRs.