From ed4919c7d46e2f000823f8d1231f965cd3740f85 Mon Sep 17 00:00:00 2001
From: Rian-Ismael <106334437+Rian-Ismael@users.noreply.github.com>
Date: Thu, 30 Jan 2025 23:01:56 -0300
Subject: [PATCH] Update WaitAllStrategyTest.java

Improves the readability of the test. Numeric literals in assertions have been replaced with descriptive constants, improving readability and making the test easier to understand, modify, and debugging efficiency.
---
 .../wait/strategy/WaitAllStrategyTest.java     | 18 ++++++++++++------
 1 file changed, 12 insertions(+), 6 deletions(-)

diff --git a/core/src/test/java/org/testcontainers/containers/wait/strategy/WaitAllStrategyTest.java b/core/src/test/java/org/testcontainers/containers/wait/strategy/WaitAllStrategyTest.java
index 8b69553e5ab..697b8e0f4ff 100644
--- a/core/src/test/java/org/testcontainers/containers/wait/strategy/WaitAllStrategyTest.java
+++ b/core/src/test/java/org/testcontainers/containers/wait/strategy/WaitAllStrategyTest.java
@@ -21,7 +21,13 @@
 import static org.mockito.Mockito.verify;
 
 public class WaitAllStrategyTest {
-
+    
+    private static final long CHILD_INITIAL_TIMEOUT = 10;
+    
+    private static final long CHILD_DIRECT_SET_TIMEOUT = 20;
+    
+    private static final long PARENT_OVERRIDE_TIMEOUT = 30;
+    
     @Mock
     private GenericContainer container;
 
@@ -44,14 +50,14 @@ public void setUp() {
      */
     @Test
     public void parentTimeoutApplies() {
-        DummyStrategy child1 = new DummyStrategy(Duration.ofMillis(10));
-        child1.withStartupTimeout(Duration.ofMillis(20));
+        DummyStrategy child1 = new DummyStrategy(Duration.ofMillis(CHILD_INITIAL_TIMEOUT));
+        child1.withStartupTimeout(Duration.ofMillis(CHILD_DIRECT_SET_TIMEOUT));
 
-        assertThat(child1.startupTimeout.toMillis()).as("withStartupTimeout directly sets the timeout").isEqualTo(20L);
+        assertThat(child1.startupTimeout.toMillis()).as("withStartupTimeout directly sets the timeout").isEqualTo(CHILD_DIRECT_SET_TIMEOUT);
 
-        new WaitAllStrategy().withStrategy(child1).withStartupTimeout(Duration.ofMillis(30));
+        new WaitAllStrategy().withStrategy(child1).withStartupTimeout(Duration.ofMillis(PARENT_OVERRIDE_TIMEOUT));
 
-        assertThat(child1.startupTimeout.toMillis()).as("WaitAllStrategy overrides a child's timeout").isEqualTo(30L);
+        assertThat(child1.startupTimeout.toMillis()).as("WaitAllStrategy overrides a child's timeout").isEqualTo(PARENT_OVERRIDE_TIMEOUT);
     }
 
     @Test