Remove redundant withExposedPorts

Author: cristianrgreco

packages/modules/kafka/src/kafka-container-7.test.ts

@@ -9,7 +9,7 @@ const IMAGE = "confluentinc/cp-kafka:7.9.1";
 describe("KafkaContainer", { timeout: 240_000 }, () => {
   // connectBuiltInZK {
   it("should connect using in-built zoo-keeper", async () => {
-    const kafkaContainer = await new KafkaContainer(IMAGE).withExposedPorts(9093).start();
+    const kafkaContainer = await new KafkaContainer(IMAGE).start();
 
     await testPubSub(kafkaContainer);
 
@@ -18,7 +18,7 @@ describe("KafkaContainer", { timeout: 240_000 }, () => {
   // }
 
   it("should connect using in-built zoo-keeper and custom images", async () => {
-    const kafkaContainer = await new KafkaContainer(IMAGE).withExposedPorts(9093).start();
+    const kafkaContainer = await new KafkaContainer(IMAGE).start();
 
     await testPubSub(kafkaContainer);
 
@@ -28,7 +28,7 @@ describe("KafkaContainer", { timeout: 240_000 }, () => {
   it("should connect using in-built zoo-keeper and custom network", async () => {
     const network = await new Network().start();
 
-    const kafkaContainer = await new KafkaContainer(IMAGE).withNetwork(network).withExposedPorts(9093).start();
+    const kafkaContainer = await new KafkaContainer(IMAGE).withNetwork(network).start();
 
     await testPubSub(kafkaContainer);
 
@@ -52,7 +52,6 @@ describe("KafkaContainer", { timeout: 240_000 }, () => {
     const kafkaContainer = await new KafkaContainer(IMAGE)
       .withNetwork(network)
       .withZooKeeper(zooKeeperHost, zooKeeperPort)
-      .withExposedPorts(9093)
       .start();
 
     await testPubSub(kafkaContainer);
@@ -191,7 +190,7 @@ describe("KafkaContainer", { timeout: 240_000 }, () => {
 
   // connectKraft {
   it("should connect using kraft", async () => {
-    const kafkaContainer = await new KafkaContainer(IMAGE).withKraft().withExposedPorts(9093).start();
+    const kafkaContainer = await new KafkaContainer(IMAGE).withKraft().start();
 
     await testPubSub(kafkaContainer);
 
@@ -207,11 +206,7 @@ describe("KafkaContainer", { timeout: 240_000 }, () => {
 
   it("should connect using kraft and custom network", async () => {
     const network = await new Network().start();
-    const kafkaContainer = await new KafkaContainer(IMAGE)
-      .withKraft()
-      .withNetwork(network)
-      .withExposedPorts(9093)
-      .start();
+    const kafkaContainer = await new KafkaContainer(IMAGE).withKraft().withNetwork(network).start();
 
     await testPubSub(kafkaContainer);
 
@@ -220,27 +215,24 @@ describe("KafkaContainer", { timeout: 240_000 }, () => {
   });
 
   it("should throw an error when using kraft wit sasl and confluence platfom below 7.5.0", async () => {
-    const kafkaContainer = new KafkaContainer("confluentinc/cp-kafka:7.4.0")
-      .withKraft()
-      .withExposedPorts(9093)
-      .withSaslSslListener({
-        port: 9094,
-        sasl: {
-          mechanism: "SCRAM-SHA-512",
-          user: {
-            name: "app-user",
-            password: "userPassword",
-          },
-        },
-        keystore: {
-          content: "fake",
-          passphrase: "serverKeystorePassword",
-        },
-        truststore: {
-          content: "fake",
-          passphrase: "serverTruststorePassword",
+    const kafkaContainer = new KafkaContainer("confluentinc/cp-kafka:7.4.0").withKraft().withSaslSslListener({
+      port: 9094,
+      sasl: {
+        mechanism: "SCRAM-SHA-512",
+        user: {
+          name: "app-user",
+          password: "userPassword",
         },
-      });
+      },
+      keystore: {
+        content: "fake",
+        passphrase: "serverKeystorePassword",
+      },
+      truststore: {
+        content: "fake",
+        passphrase: "serverTruststorePassword",
+      },
+    });
     await expect(() => kafkaContainer.start()).rejects.toThrow(
       "Provided Confluent Platform's version 7.4.0 is not supported in Kraft mode with sasl (must be 7.5.0 or above)"
     );

packages/modules/kafka/src/kafka-container-latest.test.ts

@@ -12,7 +12,7 @@ describe("KafkaContainer", { timeout: 240_000 }, () => {
 
   // connectKafkaLatest {
   it("should connect", async () => {
-    const kafkaContainer = await new KafkaContainer(IMAGE).withExposedPorts(9093).start();
+    const kafkaContainer = await new KafkaContainer(IMAGE).start();
 
     await testPubSub(kafkaContainer);
 
@@ -22,7 +22,7 @@ describe("KafkaContainer", { timeout: 240_000 }, () => {
 
   it("should connect with custom network", async () => {
     const network = await new Network().start();
-    const kafkaContainer = await new KafkaContainer(IMAGE).withNetwork(network).withExposedPorts(9093).start();
+    const kafkaContainer = await new KafkaContainer(IMAGE).withNetwork(network).start();
 
     await testPubSub(kafkaContainer);