Couchbase: add missing exports and fix sonar suggestions (#942)

Author: digital88

.github/scripts/changed-modules.sh

@@ -60,7 +60,7 @@ while IFS= read -r file; do
 done < <(find "${ROOT_DIR}" -maxdepth 1 -type f -not -name "package.json" -not -name "package-lock.json")
 
 # define an array of modules that won't be part of the build
-readonly no_build_modules=("couchbase")
+readonly no_build_modules=()
 
 # modules is an array that will store the paths of all the modules in the repository.
 modules=()

packages/modules/couchbase/src/bucket-definition.ts

@@ -4,7 +4,7 @@ export class BucketDefinition {
   private quota = 100;
   private numOfReplicas = 0;
 
-  constructor(private name: string) {}
+  constructor(private readonly name: string) {}
 
   withReplicas(numOfReplicas: number) {
     const minThreshold = 0;

packages/modules/couchbase/src/couchbase-container.ts

@@ -60,7 +60,7 @@ export class CouchbaseContainer extends GenericContainer {
 
   withServiceQuota(service: CouchbaseService, quotaMb: number) {
     if (!service.hasQuota()) {
-      throw new Error(`The provided service (${service}) has no quota to configure`);
+      throw new Error(`The provided service (${service.getIdentifier()}) has no quota to configure`);
     }
 
     if (quotaMb < service.getMinimumQuotaMb()) {
@@ -253,14 +253,14 @@ export class CouchbaseContainer extends GenericContainer {
   }
 
   private async setMemoryQuotas(container: StartedTestContainer) {
-    log.debug(`Custom service memory quotas: ${this.customServiceQuotas}`);
     for (const service of this.enabledServices) {
       if (!service.hasQuota()) {
         continue;
       }
 
       const body = new URLSearchParams();
-      const quota = this.customServiceQuotas.get(service) || service.getMinimumQuotaMb();
+      const quota = this.customServiceQuotas.get(service) ?? service.getMinimumQuotaMb();
+      log.debug(`Custom service memory quotas: ${service.getIdentifier()} - ${quota} Mb.`);
 
       if (service.getIdentifier() === CouchbaseService.KV.getIdentifier()) {
         body.set("memoryQuota", quota.toString());

packages/modules/couchbase/src/couchbase-service.ts

@@ -1,7 +1,7 @@
 export class CouchbaseService {
   constructor(
-    private identifier: string,
-    private minimumQuotaMb: number
+    private readonly identifier: string,
+    private readonly minimumQuotaMb: number
   ) {}
 
   static readonly KV = new CouchbaseService("kv", 256);

packages/modules/couchbase/src/index.ts

@@ -1 +1,3 @@
+export { BucketDefinition } from "./bucket-definition";
 export { CouchbaseContainer, StartedCouchbaseContainer } from "./couchbase-container";
+export { CouchbaseService } from "./couchbase-service";