Fix compilation issues

Author: cristianrgreco

.devcontainer/devcontainer.json

@@ -8,7 +8,7 @@
   // Features to add to the dev container. More info: https://containers.dev/features.
   "features": {
     "ghcr.io/devcontainers/features/node:1": {
-      "version": "22"
+      "version": "24"
     },
     "ghcr.io/devcontainers/features/docker-outside-of-docker:1": {}
   },

.github/workflows/npm-publish.yml

@@ -24,21 +24,21 @@ jobs:
 
       - name: Update versions
         run: |
-          npm version ${{ github.event.release.tag_name }} -ws --allow-same-version
+          npm version ${{ github.event.release.tag_name }} --ws --allow-same-version
           for module in packages/modules/*; do npm install testcontainers@${{ github.event.release.tag_name }} --save -w $module; done
           sed -i -E "s/(sonar.projectVersion)=.+/\1=${{ github.event.release.tag_name }}/" sonar-project.properties
 
       - name: Build packages
         run: |
           npm ci --omit=optional
-          npm run build -ws
+          npm run build --ws
 
       - name: Git commit and push
         run: |
           git commit -am "${{ github.event.release.tag_name }}"
           git push
 
       - name: Publish packages to NPM
-        run: npm publish -ws
+        run: npm publish --ws
         env:
           NODE_AUTH_TOKEN: ${{ secrets.npm_token }}

package.json

@@ -16,7 +16,7 @@
     "lint:ci": "eslint package.json \"${WORKSPACE_PATH}/**/*.ts\" --max-warnings=0",
     "update-deps": "npm-check-updates --workspaces --root -u",
     "validate-engine": "ls-engines",
-    "check-compiles": "npm run build --ignore-scripts -ws -- --project tsconfig.json --noEmit"
+    "check-compiles": "npm run build --ignore-scripts --ws -- --project tsconfig.json --noEmit"
   },
   "devDependencies": {
     "@eslint/js": "^9.26.0",

packages/modules/elasticsearch/src/elasticsearch-container.test.ts

@@ -27,10 +27,32 @@ describe("ElasticsearchContainer", { timeout: 180_000 }, () => {
     };
     await client.index({
       index: "people",
-      body: document,
       id: document.id,
+      document,
     });
 
+    /*
+    body?: string | ({
+        [key: string]: any;
+    } & {
+        id?: never;
+        index?: never;
+        if_primary_term?: never;
+        if_seq_no?: never;
+        include_source_on_error?: never;
+        op_type?: never;
+        pipeline?: never;
+        refresh?: never;
+        routing?: never;
+        timeout?: never;
+        version?: never;
+        version_type?: never;
+        wait_for_active_shards?: never;
+        require_alias?: never;
+        document?: never;
+    })
+     */
+
     expect((await client.get({ index: "people", id: document.id }))._source).toStrictEqual(document);
     await container.stop();
   });

packages/testcontainers/src/generic-container/generic-container-builder.ts

@@ -89,7 +89,7 @@ export class GenericContainerBuilder {
     };
 
     if (this.pullPolicy.shouldPull()) {
-      buildOptions.pull = "true";
+      buildOptions.pull = true;
     }
 
     await client.image.build(this.context, buildOptions);