fix: use a composite action

Author: mdelapenya

.github/workflows/npm-ci.yml .github/actions/npm-setup/action.yml.github/workflows/npm-ci.yml renamed to .github/actions/npm-setup/action.yml

@@ -1,21 +1,17 @@
-name: NPM Install
-run-name: "Runner (${{ inputs.runner }}) / Node (${{ inputs.node-version }})"
+name: 'NPM Setup'
+description: 'Sets up Node.js and installs NPM dependencies with caching'
 
-on:
-  workflow_call:
-    inputs:
-      runner:
-        required: true
-        type: string
-      node-version:
-        required: true
-        type: string
+inputs:
+  runner:
+    description: 'Runner to use'
+    required: true
+  node-version:
+    description: 'Node.js version to use'
+    required: true
 
-jobs:
-  npm-install:
-    name: "NPM Install (${{ inputs.runner }}) / Node (${{ inputs.node-version }})"
-    runs-on: ${{ inputs.runner }}
-    steps:
+runs:
+  using: "composite"
+  steps:
       - name: Install NodeJS ${{ inputs.node-version }}
         uses: actions/setup-node@v4
         with:
@@ -28,8 +24,9 @@ jobs:
         id: npm-cache # use this to check for `cache-hit` ==> if: steps.npm-cache.outputs.cache-hit != 'true'
         with:
           path: ${{ steps.npm-cache-dir.outputs.dir }}
-          key: ${{ inputs.runner }}-node-{{ inputs.node-version }}-${{ hashFiles('**/package-lock.json') }}
+          key: ${{ inputs.runner }}-node-${{ inputs.node-version }}-${{ hashFiles('**/package-lock.json') }}
           restore-keys: |
-            ${{ inputs.runner }}-node-{{ inputs.node-version }}-
+            ${{ inputs.runner }}-node-${{ inputs.node-version }}-
       - name: Install dependencies
+        shell: bash
         run: npm ci --omit=optional

.github/workflows/test.yml

@@ -29,10 +29,13 @@ jobs:
     steps:
       - name: Code checkout
         uses: actions/checkout@v4
-      - uses: ./.github/workflows/npm-ci.yml
+
+      # Uses a composite action for a consistent NPM install including cache
+      - uses: ./.github/actions/npm-setup
         with:
           runner: ${{ matrix.runner }}
           node-version: ${{ matrix.node-version }}
+
       - name: Build workspaces
         run: npm run build -ws
       - name: Remove dev dependencies