Type error with getMappedPort

[ALbert-Shen-code]

Hey Albert again!

I received a type error when the new version released

I think it is because the new implement of protocol, but not sure how to fix it.

Can you give some help?

Thanks!

[cristianrgreco]

Hi @ALbert-Shen-code, what testcontainers libraries are you using and what versions?

[ALbert-Shen-code]

Hi @ALbert-Shen-code, what testcontainers libraries are you using and what versions?

Oh sorry I forgot to add that... We used in node version and current version is 11.4.0

[cristianrgreco]

Hmm, the new feature which supports the protocol was released in 11.5.0, so not sure why you're seeing that on 11.4.0. Regardless updating the return type of the getMappedPort should sort it

[ALbert-Shen-code]

Oh because we created our own test library which used testcontainers as a peer dependency, and I just checked again now it was updated to 11.5.0.

[cristianrgreco]

Yep so if you're defining your own StartedTestContainer, and are overriding the getMappedPort method, then you may need to update the method signature. It should just be a signature change. If you don't care about the getMappedPort method, I'd recommend your StartedTestContainer extends AbstractStartedContainer instead.

EDIT: TBH this is my bad, I didn't think about this use case. If I had I would've released this as a major change. Hopefully it should just be a case of updating the signature and nothing more.

[ALbert-Shen-code]

All good now! thank you for your help!