Fix file-lock to handle existing lock files #1164
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed createEmptyTmpFile to use the 'wx' flag when writing the lock file, which fails if the file already exists. Added error handling to catch and ignore EEXIST errors, allowing the lock mechanism to work correctly when the lock file already exists from a previous operation. This prevents race conditions and improves robustness of the file locking mechanism by properly handling the case where multiple processes or sequential calls attempt to create the same lock file. Added comprehensive tests covering: - Basic lock functionality with sync and async functions - Lock file creation and cleanup - Error handling and lock release - Concurrent lock acquisition - Handling of existing lock files - Return value propagation
✅ Deploy Preview for testcontainers-node ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
rdziarnowski-clickup
changed the title
Collaborator
|
Hi @rdziarnowski-clickup, I don't understand what specific scenario this PR fixes. How the temporary file is created shouldn't matter. If it already exists it means we should wait for the lock to be released, not to throw an error. If I revert all the changes made to |
| import path from "path"; | ||
| import { withFileLock } from "./file-lock"; | ||
|
|
||
| describe("withFileLock", () => { |
Collaborator
There was a problem hiding this comment.
Running this test suite fails intermittently on my machine. It's because the tests by default run in parallel, and these tests which share a file lock inherently cannot run in parallel. Needs to be describe.sequential.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed createEmptyTmpFile to use the 'wx' flag when writing the lock file, which fails if the file already exists. Added error handling to catch and ignore EEXIST errors, allowing the lock mechanism to work correctly when the lock file already exists from a previous operation.
This prevents race conditions and improves robustness of the file locking mechanism by properly handling the case where multiple processes or sequential calls attempt to create the same lock file.