Skip to content

Conversation

@joebowbeer
Copy link
Contributor

@joebowbeer joebowbeer commented Dec 16, 2025

KafkaContainer changes:

  • Export SaslSslListenerOptions
  • Simplify SASL/SSL tests for readability

Working with the published container it became apparent that SaslSslListenerOptions in .withSaslSslListener(options) was not exported from the module.

All of these tests pass locally.

@netlify
Copy link

netlify bot commented Dec 16, 2025

Deploy Preview for testcontainers-node ready!

Name Link
🔨 Latest commit e9d1c86
🔍 Latest deploy log https://app.netlify.com/projects/testcontainers-node/deploys/69419def49cce20008c2145f
😎 Deploy Preview https://deploy-preview-1201--testcontainers-node.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@joebowbeer joebowbeer force-pushed the sasl-ssl-listener-options branch from 2e4d161 to e9d1c86 Compare December 16, 2025 17:59
@joebowbeer joebowbeer changed the title chore: export SaslSslListenerOptions chore: export KafkaContainer's SaslSslListenerOptions Dec 16, 2025
@joebowbeer joebowbeer marked this pull request as ready for review December 16, 2025 18:15
@cristianrgreco cristianrgreco added the maintenance Improvements that do not change functionality label Dec 16, 2025
@cristianrgreco cristianrgreco changed the title chore: export KafkaContainer's SaslSslListenerOptions Export KafkaContainer's SaslSslListenerOptions Dec 16, 2025
@cristianrgreco cristianrgreco merged commit 17930dd into testcontainers:main Dec 16, 2025
20 checks passed
@joebowbeer joebowbeer deleted the sasl-ssl-listener-options branch December 17, 2025 00:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintenance Improvements that do not change functionality

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants