Skip to content

Conversation

@kevin-pek
Copy link

No description provided.

@netlify
Copy link

netlify bot commented Jan 15, 2024

Deploy Preview for testcontainers-node ready!

Name Link
🔨 Latest commit 4af56cc
🔍 Latest deploy log https://app.netlify.com/sites/testcontainers-node/deploys/65e359544cfac500083e3596
😎 Deploy Preview https://deploy-preview-705--testcontainers-node.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@cristianrgreco
Copy link
Collaborator

Thanks @kevin-pek, the PR looks good. You'll need to add the new module to the list of modules to test here: https://github.com/testcontainers/testcontainers-node/blob/main/.github/workflows/test.yml#L82-L95

@cristianrgreco cristianrgreco added enhancement New feature or request minor Backward compatible functionality labels Jan 16, 2024
@djakielski
Copy link
Contributor

@kevin-pek please add your module to documentation reference into https://github.com/testcontainers/testcontainers-node/blob/main/mkdocs.yml#L44. Just add it in a new line and order it alphabetically.

@cristianrgreco
Copy link
Collaborator

cristianrgreco commented Feb 29, 2024

@kevin-pek Please have a look at the failing smoke test. Looks like main wasn't quite merged correctly

@cristianrgreco
Copy link
Collaborator

@kevin-pek Supertokens module tests are failing

@cristianrgreco
Copy link
Collaborator

Closing due to inactivity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request minor Backward compatible functionality

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants