-
-
Notifications
You must be signed in to change notification settings - Fork 250
Closed
Labels
enhancementNew feature or requestNew feature or requestgood first issueGood for newcomersGood for newcomers
Description
Expected Behaviour
const container = new RedisContainer('redis/redis-stack-server:7.2.0-v12')This will fail because of the redis-server command.
testcontainers-node/packages/modules/redis/src/redis-container.ts
Lines 36 to 39 in 9f7fd4e
| this.withCommand([ | |
| "redis-server", | |
| ...(this.password ? [`--requirepass "${this.password}"`] : []), | |
| ...(this.persistenceVolume ? ["--save 1 1 ", "--appendonly yes"] : []), |
As you can see from the docker images, redis uses CMD [redis-server] but redis-stack-server uses a custom entrypoint script. So I'm happy to open a PR, basically based on image string passed, we'll need to change how container.start() is handled (It's messy but not sure how else to solve it when you have 2 Redis images now!)
- https://hub.docker.com/layers/library/redis/7.2/images/sha256-74de23f6746eb84af59a6ae86e5d3c4306078dd2a45cb02bf1556ac438436e95?context=explore
- https://hub.docker.com/layers/redis/redis-stack-server/7.2.0-v12/images/sha256-af91865c72c3c51b62a15fb3bcf9eae8d958672820fc91ae5c0b4c39ff5c9b53?context=explore (redis/redis-stack-server:7.2.0-v12)
Metadata
Metadata
Assignees
Labels
enhancementNew feature or requestNew feature or requestgood first issueGood for newcomersGood for newcomers