Docs - make info about Wait Strategies easier to find #846
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I believe this is a far more important feature than to be left on the advanced features page alone. I was looking for it, and wished it was more obvious to find 🙂 I hope you accept this contribution :)
✅ Deploy Preview for testcontainers-node ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
kiview
approved these changes
Oct 22, 2024
Member
kiview
left a comment
kiview
left a comment
There was a problem hiding this comment.
I think it is a useful improvement. Also highlights, how we would benefit from language agnostic docs on the conepts.
Author
|
If you point me to the language-agnostic docs - I'll see if I can PR the same thing there :) |
Collaborator
|
Hi,
The docs for wait strategies aren't in the advanced page. They have their own top-level page 
I'd rather avoid duplicating the docs for the time being. If I hear again that someone's missed the page then I'll revisit this. Thanks for raising 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I was searching for it - I almost missed it, and found it by accident a moment before I gave up.
I believe it's a too important feature to be left only in the advanced-features page.
I tried my best to understand the order by which items appear in the
containerspage and tried to fit in.I hope you accept this :)