Skip to content

Conversation

@Anush008
Copy link
Contributor

@Anush008 Anush008 commented Mar 5, 2025

Hey 👋. Greetings from Qdrant.

QdrantContainer defaults to a specific version of Qdrant.

We had users coming from https://node.testcontainers.org/modules/qdrant/ not knowing how to specify a custom version. So this PR helps with demonstrating that.

@netlify
Copy link

netlify bot commented Mar 5, 2025

Deploy Preview for testcontainers-node ready!

Name Link
🔨 Latest commit d5197b5
🔍 Latest deploy log https://app.netlify.com/sites/testcontainers-node/deploys/67c8526dcf5a170008f543e9
😎 Deploy Preview https://deploy-preview-917--testcontainers-node.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@cristianrgreco cristianrgreco added maintenance Improvements that do not change functionality patch Backward compatible bug fix labels Mar 5, 2025
@cristianrgreco
Copy link
Collaborator

@Anush008 Tests are failing:

FAIL packages/modules/qdrant/src/qdrant-container.test.ts (17.112 s)
  QdrantContainer
    ✓ should connect to the client (7699 ms)
    ✓ should work with valid API keys (1360 ms)
    ✕ should fail for invalid API keys (1369 ms)
    ✓ should work with config files - valid API key (1352 ms)
    ✕ should work with config files - invalid API key (1332 ms)

  ● QdrantContainer › should fail for invalid API keys

    expect(received).rejects.toThrow(expected)

    Expected substring: "Forbidden"
    Received message:   "Unauthorized"

      at Object.fun [as getCollections] (../../../node_modules/@qdrant/openapi-typescript-fetch/dist/cjs/fetcher.js:172:23)
      at async QdrantClient.getCollections (../../../node_modules/@qdrant/js-client-rest/dist/cjs/qdrant-client.js:835:26)
      at Object.toThrow (../../../node_modules/expect/build/index.js:218:22)
      at Object.<anonymous> (src/qdrant-container.test.ts:45:45)

  ● QdrantContainer › should work with config files - invalid API key

    expect(received).rejects.toThrow(expected)

    Expected substring: "Forbidden"
    Received message:   "Unauthorized"

      at Object.fun [as getCollections] (../../../node_modules/@qdrant/openapi-typescript-fetch/dist/cjs/fetcher.js:172:23)
      at async QdrantClient.getCollections (../../../node_modules/@qdrant/js-client-rest/dist/cjs/qdrant-client.js:835:26)
      at Object.toThrow (../../../node_modules/expect/build/index.js:218:22)
      at Object.<anonymous> (src/qdrant-container.test.ts:74:45)

We should probably keep the version the same as in main, qdrant/qdrant:v1.8.1, otherwise it'll need to be a breaking change. This will be resolved by #867

@Anush008
Copy link
Contributor Author

Anush008 commented Mar 5, 2025

otherwise it'll need to be a breaking change

In this case, it was actually an update in the REST status message in the latter version.
Qdrant is backwards compatible.

@cristianrgreco cristianrgreco changed the title docs: Demonstrate specifying Qdrant version Update docs to demonstrate specifying Qdrant version Mar 6, 2025
@cristianrgreco cristianrgreco merged commit b6faf5d into testcontainers:main Mar 6, 2025
203 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintenance Improvements that do not change functionality patch Backward compatible bug fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants