-
-
Notifications
You must be signed in to change notification settings - Fork 251
Optimise CI to reduce runners usage, caching NPM modules when needed #918
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
cristianrgreco
merged 41 commits into
testcontainers:main
from
mdelapenya:refactor-pipeline
Mar 11, 2025
Merged
Optimise CI to reduce runners usage, caching NPM modules when needed #918
cristianrgreco
merged 41 commits into
testcontainers:main
from
mdelapenya:refactor-pipeline
Mar 11, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for testcontainers-node ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
mdelapenya
commented
Mar 5, 2025
…ich module is failing
This will reduce the number of concurrent workers, still running podman
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR doing?
This PR implements two major workflow optimizations:
Why is it important?
The combination of selective testing and optimized dependency management makes the CI pipeline both faster and more resource-efficient, while maintaining reliability by ensuring comprehensive testing when core changes are made.
How to test this
The shell script to detect changes comes with some heading comments with the different examples. Please read and execute them in your shell to understand which modules will be added to the build.
Effective measures
Before these changes, the build took ~60minutes, now it takes ~15 minutes for the full blown project (the testcontainers package adds 12 minutes to the build (6 for docker and 6 for podman), each module takes around 1-2 minutes in running all the tests). We expect that the build time for a PR targeting just one module takes around 2-3 minutes.