Skip to content

Conversation

@loikg
Copy link
Contributor

@loikg loikg commented Mar 16, 2025

Changes the wait strategy regex of the reaper container to be compatible with newer version of the ryuk image.
The regex is align with what testcontainer-java uses.

@netlify
Copy link

netlify bot commented Mar 16, 2025

Deploy Preview for testcontainers-node ready!

Name Link
🔨 Latest commit a6b71c0
🔍 Latest deploy log https://app.netlify.com/sites/testcontainers-node/deploys/67d89dcd7a39de000859d176
😎 Deploy Preview https://deploy-preview-933--testcontainers-node.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@cristianrgreco
Copy link
Collaborator

Hi @loikg, shall we update the version of ryuk used by testcontainers-node as well?

@cristianrgreco cristianrgreco added the maintenance Improvements that do not change functionality label Mar 16, 2025
@loikg
Copy link
Contributor Author

loikg commented Mar 16, 2025

Hi @cristianrgreco done I bump the ryuk image version to 0.11.0.

@cristianrgreco
Copy link
Collaborator

Thanks @loikg, just missing the defaults in the doc:

| RYUK_CONTAINER_IMAGE | testcontainers/ryuk:0.5.1 | Custom image for ryuk |

@cristianrgreco cristianrgreco added enhancement New feature or request minor Backward compatible functionality and removed maintenance Improvements that do not change functionality labels Mar 17, 2025
@cristianrgreco cristianrgreco changed the title feat: make repear wait strategy compatible with new ryuk version Update resource reaper version Mar 17, 2025
@loikg
Copy link
Contributor Author

loikg commented Mar 17, 2025

Sorry my bad i had missed the docs

@cristianrgreco cristianrgreco merged commit 5810da8 into testcontainers:main Mar 18, 2025
242 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request minor Backward compatible functionality

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants