Do not replace user-provided Localstack LAMBDA_DOCKER_FLAGS
#935
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for testcontainers-node ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
cristianrgreco
added
bug
cristianrgreco
changed the title
LAMBDA_DOCKER_FLAGS
cristianrgreco
approved these changes
Mar 17, 2025
Contributor
Author
|
@cristianrgreco Thanks for reviewing and approving this MR so quickly! Would you be able to approximately tell when the next version will be released? |
Collaborator
|
Hi @florian-nguyen, https://github.com/testcontainers/testcontainers-node/releases/tag/v10.21.0 release in progress. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improvement:
Following this fix, prevent sessionId stored in Localstack
LAMBDA_DOCKER_FLAGSfrom being overwritten when other flags are defined.