Skip to content

Update docs #950

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
cristianrgreco merged 4 commits into from
Mar 22, 2025
Merged

Update docs #950

cristianrgreco merged 4 commits into from
Mar 22, 2025

Conversation

@digital88
Copy link
Contributor

@digital88 digital88 commented Mar 21, 2025

  1. Added missing Supported Languages (took the list from here https://testcontainers.com/ ) and updated copyright year in index.md
  2. Minor addition in containers.md and images.md
  3. Added test to support claim that stopped but not removed containers can be re-used.

@netlify
Copy link

netlify bot commented Mar 21, 2025 •
edited
Loading

✅ Deploy Preview for testcontainers-node ready!

Name Link
🔨 Latest commit 6102334
🔍 Latest deploy log https://app.netlify.com/sites/testcontainers-node/deploys/67ded295d0b0780008d71ccd
😎 Deploy Preview https://deploy-preview-950--testcontainers-node.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

cristianrgreco
cristianrgreco reviewed Mar 21, 2025
View reviewed changes
@digital88 @cristianrgreco
Update docs/features/containers.md
1265eaf 
typo

Co-authored-by: Cristian Greco <[email protected]>
@cristianrgreco cristianrgreco added the maintenance Improvements that do not change functionality label Mar 22, 2025
@cristianrgreco cristianrgreco changed the title (docs): minor additions Update docs Mar 22, 2025
@cristianrgreco
Copy link
Collaborator

cristianrgreco commented Mar 22, 2025

Should we add an SVG for scala?

@digital88
Copy link
Contributor Author

digital88 commented Mar 22, 2025

Should we add an SVG for scala?

I took other logos from Testcontainers main page. That page does not have logo for scala. I just found nice scala logo here https://github.com/kaeawc/scala-logo/blob/master/img/logo.svg

The only thing is that logo is bigger than others, so I had to set <img> size explicitly using style attribute.

@cristianrgreco
Copy link
Collaborator

cristianrgreco commented Mar 22, 2025

LGTM
image

@cristianrgreco cristianrgreco merged commit 6624fd2 into testcontainers:main Mar 22, 2025
491 of 492 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cristianrgreco cristianrgreco cristianrgreco approved these changes

Assignees

No one assigned

Labels

maintenance Improvements that do not change functionality

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@digital88 @cristianrgreco