Build images with Buildkit #953
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for testcontainers-node ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Dockerfile is always sent as context to buildkit, so can't be ignored.
cristianrgreco
added
enhancement
Member
|
Hi @cristianrgreco, buildkit support via http doesn't take full advantage of buildkit capabilities. gRPC must be used instead. Just want to make this clear if this is going to be supported in tc-node, in order to avoid misunderstandings. |
Collaborator
Author
|
Hi @eddumelendez, the underlying PR to dockerode was implemented using gRPC (apocas/dockerode#766) |
Collaborator
Author
|
Replaced by #955 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull policy tests have had to be removed as we can no longer rely on Docker events to tell us if an image is being pulled.