Docs: clarified timeout unit in different places #958
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#817
Docker API itself is a little inconsistent, it uses seconds here in
stophttps://docs.docker.com/reference/api/engine/version/v1.48/#tag/Container/operation/ContainerStopand also seconds here in compose up/down https://docs.docker.com/reference/cli/docker/compose/down/
Docker is using nanoseconds in HEALTHCHECK (which testcontainers convert from milliseconds and pass down) here https://docs.docker.com/reference/api/engine/version/v1.48/#tag/Container/operation/ContainerCreate
Testcontainers APIs use millisecond consistently. I have documented timeout values to say which units they are expecting (seconds or millis, etc).