Skip to content

Conversation

@digital88
Copy link
Contributor

@digital88 digital88 commented Mar 24, 2025

#817

Docker API itself is a little inconsistent, it uses seconds here in stop https://docs.docker.com/reference/api/engine/version/v1.48/#tag/Container/operation/ContainerStop
and also seconds here in compose up/down https://docs.docker.com/reference/cli/docker/compose/down/

Docker is using nanoseconds in HEALTHCHECK (which testcontainers convert from milliseconds and pass down) here https://docs.docker.com/reference/api/engine/version/v1.48/#tag/Container/operation/ContainerCreate

Testcontainers APIs use millisecond consistently. I have documented timeout values to say which units they are expecting (seconds or millis, etc).

@netlify
Copy link

netlify bot commented Mar 24, 2025

Deploy Preview for testcontainers-node ready!

Name Link
🔨 Latest commit 012545f
🔍 Latest deploy log https://app.netlify.com/sites/testcontainers-node/deploys/67e15d9fc5444300080cb36c
😎 Deploy Preview https://deploy-preview-958--testcontainers-node.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@cristianrgreco cristianrgreco added the maintenance Improvements that do not change functionality label Mar 24, 2025
@cristianrgreco cristianrgreco merged commit 3a11d41 into testcontainers:main Mar 24, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintenance Improvements that do not change functionality

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants