Allow overriding default compose wait strategy #990
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for testcontainers-node ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
cristianrgreco
added
enhancement
Allow the default wait strategy to be overriden for docker compose environments. The default "listening ports" strategy doesn't work for distroless images and in complex setups, having to explicitly override the wait strategy for each service is error-prone.
jalaziz
force-pushed
the
compose-default-wait-strategy
branch
from
f952c2d to
ed0fbbf
Compare
Contributor
Author
|
pushed a change to fix the linting failure. |
Contributor
Author
|
All tests passed with the previous commit. I just added docs to hopefully get this over the line 🙏🏼 |
|
This change is extremely helpful, especially while working with distroless containers. Hoping to see it merged soon. |
cristianrgreco
approved these changes
Apr 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow the default wait strategy to be overriden for docker compose environments. The default "listening ports" strategy doesn't work for distroless images and in complex setups, having to explicitly override the wait strategy for each service is error-prone.