From 434dcbca2542cd151435464892faaf92eb07de3a Mon Sep 17 00:00:00 2001 From: Cristian Greco Date: Mon, 9 Jun 2025 15:42:33 +0100 Subject: [PATCH] Fix flaky Kafka test --- packages/modules/kafka/src/kafka-container.test.ts | 6 +++++- packages/modules/kafka/src/kafka-container.ts | 6 ------ 2 files changed, 5 insertions(+), 7 deletions(-) diff --git a/packages/modules/kafka/src/kafka-container.test.ts b/packages/modules/kafka/src/kafka-container.test.ts index 658b6c1d4..710849e49 100644 --- a/packages/modules/kafka/src/kafka-container.test.ts +++ b/packages/modules/kafka/src/kafka-container.test.ts @@ -29,7 +29,11 @@ describe("KafkaContainer", { timeout: 240_000 }, () => { it("should connect using in-built zoo-keeper and custom network", async () => { const network = await new Network().start(); - const kafkaContainer = await new KafkaContainer(IMAGE).withNetwork(network).withExposedPorts(9093).start(); + const kafkaContainer = await new KafkaContainer(IMAGE) + .withNetwork(network) + .withNetworkAliases("kafka") + .withExposedPorts(9093) + .start(); await testPubSub(kafkaContainer); diff --git a/packages/modules/kafka/src/kafka-container.ts b/packages/modules/kafka/src/kafka-container.ts index 9909b9749..d9f43671e 100644 --- a/packages/modules/kafka/src/kafka-container.ts +++ b/packages/modules/kafka/src/kafka-container.ts @@ -300,17 +300,11 @@ export class KafkaContainer extends GenericContainer { } private commandZookeeper(): string { - const port = DEFAULT_ZOOKEEPER_PORT; - let command = `echo 'clientPort=${DEFAULT_ZOOKEEPER_PORT}' > zookeeper.properties\n`; command += "echo 'dataDir=/var/lib/zookeeper/data' >> zookeeper.properties\n"; command += "echo 'dataLogDir=/var/lib/zookeeper/log' >> zookeeper.properties\n"; command += "zookeeper-server-start zookeeper.properties &\n"; - command += `echo "Waiting for ZooKeeper to be ready on port ${port}..."\n`; - command += `while ! (echo > /dev/tcp/localhost/${port}) &> /dev/null; do sleep 0.1; done\n`; - command += `echo "ZooKeeper is ready."\n`; - return command; } }