Skip to content

Commit 255f8f2

Browse files
committed
return dialect to test, fix typing error
1 parent 09bf71c commit 255f8f2

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

modules/mysql/tests/test_mysql.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -11,12 +11,12 @@
1111

1212
@pytest.mark.inside_docker_check
1313
def test_docker_run_mysql():
14-
config = MySqlContainer("mysql:8.3.0")
14+
config = MySqlContainer("mysql:8.3.0", dialect="pymysql")
1515
with config as mysql:
1616
connection_url = mysql.get_connection_url()
1717

18-
assert mysql.dialect is None
19-
assert connection_url.startswith("mysql://")
18+
assert mysql.dialect == "pymysql"
19+
assert connection_url.startswith("mysql+pymysql://")
2020

2121
engine = sqlalchemy.create_engine(connection_url)
2222
with engine.begin() as connection:
@@ -40,7 +40,7 @@ def test_docker_run_legacy_mysql():
4040
def test_docker_run_mysql_8_seed():
4141
# Avoid pytest CWD path issues
4242
SEEDS_PATH = (Path(__file__).parent / "seeds").absolute()
43-
config = MySqlContainer("mysql:8", seed=SEEDS_PATH)
43+
config = MySqlContainer("mysql:8", seed=str(SEEDS_PATH))
4444
with config as mysql:
4545
engine = sqlalchemy.create_engine(mysql.get_connection_url())
4646
with engine.begin() as connection:

0 commit comments

Comments
 (0)