Skip to content

Commit 38bfa41

Browse files
committed
improve flow
1 parent e31efa2 commit 38bfa41

File tree

2 files changed

+10
-10
lines changed

2 files changed

+10
-10
lines changed

.github/workflows/ci-lint.yml

Lines changed: 6 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -20,20 +20,17 @@ jobs:
2020
- name: Install Python dependencies
2121
run: poetry install --no-interaction
2222
- name: Execute pre-commit handler
23+
continue-on-error: true
2324
run: |
2425
poetry run pre-commit run check-toml
2526
poetry run pre-commit run trailing-whitespace
2627
poetry run pre-commit run end-of-file-fixer
2728
poetry run pre-commit run ruff
2829
poetry run pre-commit run ruff-format
2930
- name: Execute mypy
31+
continue-on-error: true
3032
run: |
31-
poetry run mypy --config-file pyproject.toml core > mypy.log 2>&1
32-
if [ -s mypy.log ]; then
33-
cat mypy.log
34-
echo "Mypy issues found. Generating report...";
35-
cat mypy.log | poetry run python scripts/mypy_report.py
36-
exit 1
37-
else
38-
echo "No mypy issues found.";
39-
fi
33+
make mypy-core
34+
- name: generate mypy report
35+
run: |
36+
make mypy-core-report

Makefile

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,10 @@ coverage: ## Target to combine and report coverage.
3131
lint: ## Lint all files in the project, which we also run in pre-commit
3232
poetry run pre-commit run -a
3333

34-
mypy-core-report:
34+
mypy-core: ## Run mypy on the core package
35+
poetry run mypy --config-file pyproject.toml core
36+
37+
mypy-core-report: ## Generate a report for mypy on the core package
3538
poetry run mypy --config-file pyproject.toml core | poetry run python scripts/mypy_report.py
3639

3740
docs: ## Build the docs for the project

0 commit comments

Comments
 (0)