Rename db_name to dbname.

Author: tillahoffmann

clickhouse/testcontainers/clickhouse/__init__.py

@@ -72,7 +72,7 @@ def get_connection_url(self, host: Optional[str] = None) -> str:
             dialect="clickhouse",
             username=self.username,
             password=self.password,
-            db_name=self.dbname,
+            dbname=self.dbname,
             host=host,
             port=self.port_to_expose,
         )

core/testcontainers/core/generic.py

@@ -39,14 +39,16 @@ def get_connection_url(self) -> str:
 
     def _create_connection_url(self, dialect: str, username: str, password: str,
                                host: Optional[str] = None, port: Optional[int] = None,
-                               db_name: Optional[str] = None) -> str:
+                               dbname: Optional[str] = None, db_name: None = None) -> str:
+        if db_name:
+            raise ValueError("use `dbname` instead of `db_name`")
         if self._container is None:
             raise ContainerStartException("container has not been started")
         host = host or self.get_container_host_ip()
         port = self.get_exposed_port(port)
         url = f"{dialect}://{username}:{password}@{host}:{port}"
-        if db_name:
-            url = f"{url}/{db_name}"
+        if dbname:
+            url = f"{url}/{dbname}"
         return url
 
     def start(self) -> 'DbContainer':

mssql/testcontainers/mssql/__init__.py

@@ -45,5 +45,5 @@ def _configure(self) -> None:
     def get_connection_url(self) -> str:
         return super()._create_connection_url(
             dialect=self.dialect, username=self.username, password=self.password,
-            db_name=self.dbname, port=self.port_to_expose
+            dbname=self.dbname, port=self.port_to_expose
         )

mysql/testcontainers/mysql/__init__.py

@@ -74,5 +74,5 @@ def get_connection_url(self) -> str:
         return super()._create_connection_url(dialect="mysql+pymysql",
                                               username=self.username,
                                               password=self.password,
-                                              db_name=self.dbname,
+                                              dbname=self.dbname,
                                               port=self.port_to_expose)

oracle/testcontainers/oracle/__init__.py

@@ -27,7 +27,7 @@ def __init__(self, image: str = "wnameless/oracle-xe-11g-r2:latest", **kwargs) -
     def get_connection_url(self) -> str:
         return super()._create_connection_url(
             dialect="oracle", username="system", password="oracle", port=self.container_port,
-            db_name="xe"
+            dbname="xe"
         )
 
     def _configure(self) -> None:

postgres/testcontainers/postgres/__init__.py

@@ -61,6 +61,6 @@ def _configure(self) -> None:
     def get_connection_url(self, host=None) -> str:
         return super()._create_connection_url(
             dialect=f"postgresql+{self.driver}", username=self.username,
-            password=self.password, db_name=self.dbname, host=host,
+            password=self.password, dbname=self.dbname, host=host,
             port=self.port_to_expose,
         )