Skip to content

Commit 4b761ba

Browse files
Merge pull request #286 from spicy-sauce/mssql-exposed-ports
SqlServerContainer - can't bind port #285
2 parents 31af452 + c12cd9b commit 4b761ba

File tree

1 file changed

+3
-2
lines changed

1 file changed

+3
-2
lines changed

testcontainers/mssql.py

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -28,14 +28,15 @@ def __init__(self, image="mcr.microsoft.com/mssql/server:2019-latest", user="SA"
2828
port=1433, dbname="tempdb", dialect='mssql+pymssql', **kwargs):
2929
super(SqlServerContainer, self).__init__(image, **kwargs)
3030

31-
self.SQLSERVER_PASSWORD = password or environ.get("SQLSERVER_PASSWORD", "1Secure*Password1")
3231
self.port_to_expose = port
32+
self.with_exposed_ports(self.port_to_expose)
33+
34+
self.SQLSERVER_PASSWORD = password or environ.get("SQLSERVER_PASSWORD", "1Secure*Password1")
3335
self.SQLSERVER_USER = user
3436
self.SQLSERVER_DBNAME = dbname
3537
self.dialect = dialect
3638

3739
def _configure(self):
38-
self.with_exposed_ports(self.port_to_expose)
3940
self.with_env("SA_PASSWORD", self.SQLSERVER_PASSWORD)
4041
self.with_env("SQLSERVER_USER", self.SQLSERVER_USER)
4142
self.with_env("SQLSERVER_DBNAME", self.SQLSERVER_DBNAME)

0 commit comments

Comments
 (0)