Review comments: add explicit parameters to __init__

Author: annabaas

testcontainers/mssql.py

@@ -5,26 +5,21 @@
 
 class SqlServerContainer(DbContainer):
     SQLSERVER_PASSWORD = environ.get("SQLSERVER_PASSWORD", "1Secure*Password1")
-    SQLSERVER_USER = "SA"
-    SQLSERVER_DBNAME = "tempdb"
-    SQLSERVER_DRIVER = "ODBC Driver 17 for SQL Server"
 
-    def __init__(self, image="mcr.microsoft.com/mssql/server:2019-latest", **kwargs):
+    def __init__(self, image="mcr.microsoft.com/mssql/server:2019-latest", user="SA", password=None,
+                 port=1433, dbname="tempdb", driver="ODBC Driver 17 for SQL Server"):
         super(SqlServerContainer, self).__init__(image)
-        self.port_to_expose = 1433
+
+        self.SQLSERVER_PASSWORD = password or self.SQLSERVER_PASSWORD
+        self.port_to_expose = port
+        self.SQLSERVER_USER = user
+        self.SQLSERVER_DBNAME = dbname
+        self.SQLSERVER_DRIVER = driver
+
         self.with_exposed_ports(self.port_to_expose)
         self.ACCEPT_EULA = 'Y'
         self.MSSQL_PID = 'Developer'
 
-        if 'SQLSERVER_PASSWORD' in kwargs:
-            self.SQLSERVER_PASSWORD = kwargs['SQLSERVER_PASSWORD']
-        if 'SQLSERVER_USER' in kwargs:
-            self.SQLSERVER_USER = kwargs['SQLSERVER_USER']
-        if 'SQLSERVER_DBNAME' in kwargs:
-            self.SQLSERVER_DBNAME = kwargs['SQLSERVER_DBNAME']
-        if 'SQLSERVER_DRIVER' in kwargs:
-            self.SQLSERVER_DRIVER = kwargs['SQLSERVER_DRIVER']
-
     def _configure(self):
         self.with_env("SA_PASSWORD", self.SQLSERVER_PASSWORD)
         self.with_env("SQLSERVER_USER", self.SQLSERVER_USER)