Skip to content

Commit 4c7a67f

Browse files
committed
Renamed SqlConnectWaitStrategy
1 parent 6694e44 commit 4c7a67f

File tree

5 files changed

+9
-9
lines changed

5 files changed

+9
-9
lines changed

modules/generic/README.rst

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -60,14 +60,14 @@ Postgres container that is using :code:`SqlContainer`
6060
.. doctest::
6161

6262
>>> from testcontainers.generic import SqlContainer
63-
>>> from testcontainers.generic.providers.sql_connection_wait_strategy import SqlConnectWaitStrategy
63+
>>> from testcontainers.generic.providers.sql_connection_wait_strategy import SqlAlchemyConnectWaitStrategy
6464
>>> from sqlalchemy import text
6565
>>> import sqlalchemy
6666

6767
>>> class CustomPostgresContainer(SqlContainer):
6868
... def __init__(self, image="postgres:15-alpine",
6969
... port=5432, username="test", password="test", dbname="test"):
70-
... super().__init__(image=image, wait_strategy=SqlConnectWaitStrategy())
70+
... super().__init__(image=image, wait_strategy=SqlAlchemyConnectWaitStrategy())
7171
... self.port_to_expose = port
7272
... self.username = username
7373
... self.password = password
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
from .sql_connection_wait_strategy import SqlConnectWaitStrategy # noqa: F401
1+
from .sql_connection_wait_strategy import SqlAlchemyConnectWaitStrategy # noqa: F401

modules/generic/testcontainers/generic/providers/sql_connection_wait_strategy.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@
1616
logger.debug("SQLAlchemy not available, skipping DBAPIError handling")
1717

1818

19-
class SqlConnectWaitStrategy(WaitStrategy):
19+
class SqlAlchemyConnectWaitStrategy(WaitStrategy):
2020
"""Wait strategy for database connectivity testing using SQLAlchemy."""
2121

2222
def __init__(self):

modules/generic/testcontainers/generic/sql.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ class SqlContainer(DockerContainer):
1717
It provides connection management, URL construction, and basic lifecycle methods.
1818
Database connection readiness is automatically handled by the provided wait strategy.
1919
20-
Note: `SqlConnectWaitStrategy` from `sql_connection_wait_strategy` is a provided wait strategy for SQL databases.
20+
Note: `SqlAlchemyConnectWaitStrategy` from `sql_connection_wait_strategy` is a provided wait strategy for SQL databases.
2121
"""
2222

2323
def __init__(self, image: str, wait_strategy: WaitStrategy, **kwargs):

modules/generic/tests/test_sql.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -3,14 +3,14 @@
33

44
from testcontainers.core.exceptions import ContainerStartException
55
from testcontainers.generic.sql import SqlContainer
6-
from testcontainers.generic.providers.sql_connection_wait_strategy import SqlConnectWaitStrategy
6+
from testcontainers.generic.providers.sql_connection_wait_strategy import SqlAlchemyConnectWaitStrategy
77

88

99
class SimpleSqlContainer(SqlContainer):
1010
"""Simple concrete implementation for testing."""
1111

1212
def __init__(self, image: str = "postgres:13"):
13-
super().__init__(image, wait_strategy=SqlConnectWaitStrategy())
13+
super().__init__(image, wait_strategy=SqlAlchemyConnectWaitStrategy())
1414
self.username = "testuser"
1515
self.password = "testpass"
1616
self.dbname = "testdb"
@@ -30,7 +30,7 @@ def _configure(self) -> None:
3030

3131
class TestSqlContainer:
3232
def test_abstract_methods_raise_not_implemented(self):
33-
container = SqlContainer("test:latest", SqlConnectWaitStrategy())
33+
container = SqlContainer("test:latest", SqlAlchemyConnectWaitStrategy())
3434

3535
with pytest.raises(NotImplementedError):
3636
container.get_connection_url()
@@ -39,7 +39,7 @@ def test_abstract_methods_raise_not_implemented(self):
3939
container._configure()
4040

4141
def test_transfer_seed_default_behavior(self):
42-
container = SqlContainer("test:latest", SqlConnectWaitStrategy())
42+
container = SqlContainer("test:latest", SqlAlchemyConnectWaitStrategy())
4343
# Should not raise an exception
4444
container._transfer_seed()
4545

0 commit comments

Comments
 (0)