Skip to content

Commit 5f241ce

Browse files
test tweaks
1 parent dc9df40 commit 5f241ce

File tree

3 files changed

+5
-3
lines changed

3 files changed

+5
-3
lines changed

core/testcontainers/core/container.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -251,7 +251,9 @@ def get_exposed_port(self, port: int) -> int:
251251
from testcontainers.core.wait_strategies import ContainerStatusWaitStrategy as C
252252

253253
C().wait_until_ready(self)
254+
return self._get_exposed_port(port)
254255

256+
def _get_exposed_port(self, port: int) -> int:
255257
if self.get_docker_client().get_connection_mode().use_mapped_port:
256258
c = self._container
257259
assert c is not None

core/tests/test_container.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -67,14 +67,14 @@ def fake_mapped(container_id: str, port: int) -> int:
6767
monkeypatch.setattr(client, "port", fake_mapped)
6868
monkeypatch.setattr(client, "get_connection_mode", lambda: mode)
6969

70-
assert container.get_exposed_port(8080) == 45678
70+
assert container._get_exposed_port(8080) == 45678
7171

7272

7373
def test_get_exposed_port_original(container: DockerContainer, monkeypatch: pytest.MonkeyPatch) -> None:
7474
client = container._docker
7575
monkeypatch.setattr(client, "get_connection_mode", lambda: ConnectionMode.bridge_ip)
7676

77-
assert container.get_exposed_port(8080) == 8080
77+
assert container._get_exposed_port(8080) == 8080
7878

7979

8080
@pytest.mark.parametrize(

core/tests/test_wait_strategies.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -484,7 +484,7 @@ def test_wait_until_ready(self, mock_sleep, mock_time, mock_socket, connection_s
484484
strategy.wait_until_ready(mock_container)
485485
mock_socket_instance.connect.assert_called_once_with(("localhost", 8080))
486486
else:
487-
with pytest.raises(TimeoutError, match="Port 8080 not available within 1 seconds"):
487+
with pytest.raises(TimeoutError, match="Port 8080 not available within 1.0 seconds"):
488488
strategy.wait_until_ready(mock_container)
489489

490490

0 commit comments

Comments
 (0)