test(compose): improve compose tests when running specific services

Author: balint-backmaker

compose/tests/test_docker_compose.py

@@ -39,7 +39,7 @@ def test_can_build_images_before_spawning_service_via_compose():
     assert "--build" in docker_compose_cmd
 
 
-def test_can_run_specific_services():
+def test_can_specify_services():
     with patch.object(DockerCompose, "_call_command") as call_mock:
         with DockerCompose(ROOT, services=["hub", "firefox"]) as compose:
             ...
@@ -52,6 +52,25 @@ def test_can_run_specific_services():
     assert "chrome" not in docker_compose_cmd
 
 
+@pytest.mark.parametrize("should_run_hub", [
+    [True],
+    [False],
+])
+def test_can_run_specific_services(should_run_hub: bool):
+    # compose V2 will improve this test by being able to assert that "firefox" also has started and exited
+    services = ["firefox"]
+    if should_run_hub:
+        services.append("hub")
+
+    with DockerCompose(ROOT, services=services) as compose:
+        if should_run_hub:
+            assert compose.get_service_host("hub", 4444)
+            assert compose.get_service_port("hub", 4444)
+        else:
+            with pytest.raises(NoSuchPortExposed):
+                assert compose.get_service_host("hub", 4444)
+
+
 def test_can_throw_exception_if_no_port_exposed():
     with DockerCompose(ROOT) as compose:
         with pytest.raises(NoSuchPortExposed):