Skip to content

Commit acea76c

Browse files
authored
Merge branch 'main' into with_env_files
2 parents ae3d162 + f1d8d35 commit acea76c

File tree

2 files changed

+3
-2
lines changed

2 files changed

+3
-2
lines changed

.github/CONTRIBUTING.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ You need to have the following tools available to you:
3939

4040
## Adding new containers
4141

42-
We have an [issue template](.github/ISSUE_TEMPLATE/new-container.md) for adding new containers, please refer to that for more information.
42+
We have an [issue template](./ISSUE_TEMPLATE/new-container.md) for adding new containers, please refer to that for more information.
4343
Once you've talked to the maintainers (we do our best to reply!) then you can proceed with contributing the new container.
4444

4545
> [!WARNING]

modules/vault/testcontainers/vault/__init__.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@
1212
# under the License.
1313

1414
from http.client import HTTPException
15+
from urllib.error import URLError
1516
from urllib.request import urlopen
1617

1718
from testcontainers.core.container import DockerContainer
@@ -61,7 +62,7 @@ def get_connection_url(self) -> str:
6162
exposed_port = self.get_exposed_port(self.port)
6263
return f"http://{host_ip}:{exposed_port}"
6364

64-
@wait_container_is_ready(HTTPException)
65+
@wait_container_is_ready(HTTPException, URLError)
6566
def _healthcheck(self) -> None:
6667
url = f"{self.get_connection_url()}/v1/sys/health"
6768
with urlopen(url) as res:

0 commit comments

Comments
 (0)