Skip to content

Commit bf6ff4b

Browse files
committed
Add type annotations for mysql.
1 parent 8ce7231 commit bf6ff4b

File tree

1 file changed

+6
-10
lines changed

1 file changed

+6
-10
lines changed

mysql/testcontainers/mysql/__init__.py

Lines changed: 6 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111
# License for the specific language governing permissions and limitations
1212
# under the License.
1313
from os import environ
14-
14+
from typing import Optional
1515
from testcontainers.core.generic import DbContainer
1616

1717

@@ -36,13 +36,9 @@ class MySqlContainer(DbContainer):
3636
... version, = result.fetchone()
3737
"""
3838

39-
def __init__(self,
40-
image="mysql:latest",
41-
MYSQL_USER=None,
42-
MYSQL_ROOT_PASSWORD=None,
43-
MYSQL_PASSWORD=None,
44-
MYSQL_DATABASE=None,
45-
**kwargs):
39+
def __init__(self, image: str = "mysql:latest", MYSQL_USER: Optional[str] = None,
40+
MYSQL_ROOT_PASSWORD: Optional[str] = None, MYSQL_PASSWORD: Optional[str] = None,
41+
MYSQL_DATABASE: Optional[str] = None, **kwargs) -> None:
4642
super(MySqlContainer, self).__init__(image, **kwargs)
4743
self.port_to_expose = 3306
4844
self.with_exposed_ports(self.port_to_expose)
@@ -54,15 +50,15 @@ def __init__(self,
5450
if self.MYSQL_USER == 'root':
5551
self.MYSQL_ROOT_PASSWORD = self.MYSQL_PASSWORD
5652

57-
def _configure(self):
53+
def _configure(self) -> None:
5854
self.with_env("MYSQL_ROOT_PASSWORD", self.MYSQL_ROOT_PASSWORD)
5955
self.with_env("MYSQL_DATABASE", self.MYSQL_DATABASE)
6056

6157
if self.MYSQL_USER != "root":
6258
self.with_env("MYSQL_USER", self.MYSQL_USER)
6359
self.with_env("MYSQL_PASSWORD", self.MYSQL_PASSWORD)
6460

65-
def get_connection_url(self):
61+
def get_connection_url(self) -> str:
6662
return super()._create_connection_url(dialect="mysql+pymysql",
6763
username=self.MYSQL_USER,
6864
password=self.MYSQL_PASSWORD,

0 commit comments

Comments
 (0)