Replace pymmsql with pyodbc. This will probably break because the driver isn't installed on Travis.

Author: annabaas

.travis.yml

@@ -7,6 +7,9 @@ services:
 
 addons:
     chrome: "stable"
+    apt:
+      packages:
+        - unixodbc-dev # required for pyodbc
 
 language: python
 python:

requirements/3.5.txt

@@ -38,6 +38,7 @@ mccabe==0.6.1             # via flake8
 more-itertools==8.2.0     # via pytest
 packaging==20.1           # via pytest
 paramiko==2.7.1           # via docker
+pathlib2==2.3.5           # via pytest
 pluggy==0.13.1            # via pytest
 protobuf==3.11.3          # via google-api-core, googleapis-common-protos
 psycopg2-binary==2.8.4    # via testcontainers
@@ -48,9 +49,9 @@ pycodestyle==2.5.0        # via flake8
 pycparser==2.19           # via cffi
 pyflakes==2.1.1           # via flake8
 pymongo==3.10.1           # via testcontainers
-pymssql==2.1.4            # via testcontainers
 pymysql==0.9.3            # via testcontainers
 pynacl==1.3.0             # via paramiko
+pyodbc==4.0.30            # via testcontainers
 pyparsing==2.4.6          # via packaging
 pyrsistent==0.15.7        # via jsonschema
 pytest-cov==2.8.1         # via -r requirements.in
@@ -61,7 +62,7 @@ redis==3.4.1              # via testcontainers
 requests==2.23.0          # via codecov, docker, docker-compose, google-api-core
 rsa==4.0                  # via google-auth
 selenium==3.141.0         # via testcontainers
-six==1.14.0               # via bcrypt, cryptography, docker, docker-compose, dockerpty, google-api-core, google-auth, grpcio, jsonschema, packaging, protobuf, pynacl, pyrsistent, websocket-client
+six==1.14.0               # via bcrypt, cryptography, docker, docker-compose, dockerpty, google-api-core, google-auth, grpcio, jsonschema, packaging, pathlib2, protobuf, pynacl, pyrsistent, websocket-client
 sqlalchemy==1.3.13        # via testcontainers
 texttable==1.6.2          # via docker-compose
 urllib3==1.25.8           # via requests, selenium

requirements/3.6.txt

@@ -48,9 +48,9 @@ pycodestyle==2.5.0        # via flake8
 pycparser==2.19           # via cffi
 pyflakes==2.1.1           # via flake8
 pymongo==3.10.1           # via testcontainers
-pymssql==2.1.4            # via testcontainers
 pymysql==0.9.3            # via testcontainers
 pynacl==1.3.0             # via paramiko
+pyodbc==4.0.30            # via testcontainers
 pyparsing==2.4.6          # via packaging
 pyrsistent==0.15.7        # via jsonschema
 pytest-cov==2.8.1         # via -r requirements.in

requirements/3.7.txt

@@ -48,9 +48,9 @@ pycodestyle==2.5.0        # via flake8
 pycparser==2.19           # via cffi
 pyflakes==2.1.1           # via flake8
 pymongo==3.10.1           # via testcontainers
-pymssql==2.1.4            # via testcontainers
 pymysql==0.9.3            # via testcontainers
 pynacl==1.3.0             # via paramiko
+pyodbc==4.0.30            # via testcontainers
 pyparsing==2.4.6          # via packaging
 pyrsistent==0.15.7        # via jsonschema
 pytest-cov==2.8.1         # via -r requirements.in

requirements/3.8.txt

@@ -47,9 +47,9 @@ pycodestyle==2.5.0        # via flake8
 pycparser==2.19           # via cffi
 pyflakes==2.1.1           # via flake8
 pymongo==3.10.1           # via testcontainers
-pymssql==2.1.4            # via testcontainers
 pymysql==0.9.3            # via testcontainers
 pynacl==1.3.0             # via paramiko
+pyodbc==4.0.30            # via testcontainers
 pyparsing==2.4.6          # via packaging
 pyrsistent==0.15.7        # via jsonschema
 pytest-cov==2.8.1         # via -r requirements.in

setup.py

@@ -56,7 +56,7 @@
         'google-cloud-pubsub': ['google-cloud-pubsub'],
         'mongo': ['pymongo'],
         'redis': ['redis'],
-        'mssqlserver': ['pymssql']
+        'mssqlserver': ['pyodbc']
     },
     long_description_content_type="text/markdown",
     long_description=long_description,

testcontainers/mssql.py

@@ -7,6 +7,7 @@ class SqlServerContainer(DbContainer):
     SQLSERVER_PASSWORD = environ.get("SQLSERVER_PASSWORD", "1Secure*Password1")
     SQLSERVER_USER = "SA"
     SQLSERVER_DBNAME = "tempdb"
+    SQLSERVER_DRIVER = "ODBC Driver 17 for SQL Server"
 
     def __init__(self, image="mcr.microsoft.com/mssql/server:2019-latest", **kwargs):
         super(SqlServerContainer, self).__init__(image)
@@ -21,6 +22,8 @@ def __init__(self, image="mcr.microsoft.com/mssql/server:2019-latest", **kwargs)
             self.SQLSERVER_USER = kwargs['SQLSERVER_USER']
         if 'SQLSERVER_DBNAME' in kwargs:
             self.SQLSERVER_DBNAME = kwargs['SQLSERVER_DBNAME']
+        if 'SQLSERVER_DRIVER' in kwargs:
+            self.SQLSERVER_DRIVER = kwargs['SQLSERVER_DRIVER']
 
     def _configure(self):
         self.with_env("SA_PASSWORD", self.SQLSERVER_PASSWORD)
@@ -30,8 +33,10 @@ def _configure(self):
         self.with_env("MSSQL_PID", self.MSSQL_PID)
 
     def get_connection_url(self):
-        return super()._create_connection_url(dialect="mssql+pymssql",
+        standard_url = super()._create_connection_url(dialect="mssql+pyodbc",
                                               username=self.SQLSERVER_USER,
                                               password=self.SQLSERVER_PASSWORD,
                                               db_name=self.SQLSERVER_DBNAME,
                                               port=self.port_to_expose)
+
+        return standard_url + f"?driver={self.SQLSERVER_DRIVER}"