Allow passing in any parameters supported by docker (#34)

Author: weixu365

testcontainers/core/container.py

@@ -8,7 +8,7 @@
 
 
 class DockerContainer(object):
-    def __init__(self, image):
+    def __init__(self, image, **kargs):
         self.env = {}
         self.ports = {}
         self.volumes = {}
@@ -17,6 +17,7 @@ def __init__(self, image):
         self._container = None
         self._command = None
         self._name = None
+        self._kargs = kargs
 
     def with_env(self, key: str, value: str) -> 'DockerContainer':
         self.env[key] = value
@@ -32,6 +33,10 @@ def with_exposed_ports(self, *ports) -> 'DockerContainer':
             self.ports[port] = None
         return self
 
+    def with_kargs(self, **kargs) -> 'DockerContainer':
+        self._kargs = kargs
+        return self
+
     def start(self):
         print("")
         print("{} {}".format(crayons.yellow("Pulling image"),
@@ -44,7 +49,9 @@ def start(self):
                                                 environment=self.env,
                                                 ports=self.ports,
                                                 name=self._name,
-                                                volumes=self.volumes)
+                                                volumes=self.volumes,
+                                                **self._kargs
+                                                )
         print("")
         print("Container started: ",
               crayons.yellow(self._container.short_id, bold=True))

tests/test_new_docker_api.py

@@ -1,4 +1,5 @@
 import os
+from pathlib import Path
 
 from testcontainers import mysql
 
@@ -30,3 +31,17 @@ def test_docker_env_variables():
     with db:
         url = db.get_connection_url()
         assert url == 'mysql+pymysql://demo:[email protected]:32785/custom_db'
+
+def test_docker_kargs():
+    code_dir = Path(__file__).parent
+    container_first = GenericContainer("nginx:latest")
+    container_first.with_volume_mapping(code_dir, '/code')
+
+    container_second = GenericContainer("nginx:latest")
+
+    with container_first:
+        container_second.with_kargs(volumes_from=[container_first._container.short_id])
+        with container_second:
+            files_first = container_first.exec('ls /code').output.decode('utf-8').strip()
+            files_second = container_second.exec('ls /code').output.decode('utf-8').strip()
+            assert files_first == files_second