Skip to content

Commit e7f3051

Browse files
Merge pull request #308 from tillahoffmann/deps
Update dependencies.
2 parents 93ce2ad + ecd21e9 commit e7f3051

File tree

12 files changed

+217
-191
lines changed

12 files changed

+217
-191
lines changed

mssql/testcontainers/mssql/__init__.py

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,8 +15,9 @@ class SqlServerContainer(DbContainer):
1515
>>> from testcontainers.mssql import SqlServerContainer
1616
1717
>>> with SqlServerContainer() as mssql:
18-
... e = sqlalchemy.create_engine(mssql.get_connection_url())
19-
... result = e.execute("select @@VERSION")
18+
... engine = sqlalchemy.create_engine(mssql.get_connection_url())
19+
... with engine.begin() as connection:
20+
... result = connection.execute(sqlalchemy.text("select @@VERSION"))
2021
"""
2122

2223
def __init__(self, image: str = "mcr.microsoft.com/mssql/server:2019-latest", user: str = "SA",

mssql/tests/test_mssql.py

Lines changed: 10 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -6,13 +6,15 @@ def test_docker_run_mssql():
66
image = 'mcr.microsoft.com/azure-sql-edge'
77
dialect = 'mssql+pymssql'
88
with SqlServerContainer(image, dialect=dialect) as mssql:
9-
e = sqlalchemy.create_engine(mssql.get_connection_url())
10-
result = e.execute('select @@servicename')
11-
for row in result:
12-
assert row[0] == 'MSSQLSERVER'
9+
engine = sqlalchemy.create_engine(mssql.get_connection_url())
10+
with engine.begin() as connection:
11+
result = connection.execute(sqlalchemy.text('select @@servicename'))
12+
for row in result:
13+
assert row[0] == 'MSSQLSERVER'
1314

1415
with SqlServerContainer(image, password="1Secure*Password2", dialect=dialect) as mssql:
15-
e = sqlalchemy.create_engine(mssql.get_connection_url())
16-
result = e.execute('select @@servicename')
17-
for row in result:
18-
assert row[0] == 'MSSQLSERVER'
16+
engine = sqlalchemy.create_engine(mssql.get_connection_url())
17+
with engine.begin() as connection:
18+
result = connection.execute(sqlalchemy.text('select @@servicename'))
19+
for row in result:
20+
assert row[0] == 'MSSQLSERVER'

mysql/testcontainers/mysql/__init__.py

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -32,9 +32,10 @@ class MySqlContainer(DbContainer):
3232
>>> from testcontainers.mysql import MySqlContainer
3333
3434
>>> with MySqlContainer('mysql:5.7.17') as mysql:
35-
... e = sqlalchemy.create_engine(mysql.get_connection_url())
36-
... result = e.execute("select version()")
37-
... version, = result.fetchone()
35+
... engine = sqlalchemy.create_engine(mysql.get_connection_url())
36+
... with engine.begin() as connection:
37+
... result = connection.execute(sqlalchemy.text("select version()"))
38+
... version, = result.fetchone()
3839
"""
3940

4041
def __init__(self, image: str = "mysql:latest", MYSQL_USER: Optional[str] = None,

mysql/tests/test_mysql.py

Lines changed: 10 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -10,18 +10,20 @@
1010
def test_docker_run_mysql():
1111
config = MySqlContainer('mysql:5.7.17')
1212
with config as mysql:
13-
e = sqlalchemy.create_engine(mysql.get_connection_url())
14-
result = e.execute("select version()")
15-
for row in result:
16-
assert row[0].startswith('5.7.17')
13+
engine = sqlalchemy.create_engine(mysql.get_connection_url())
14+
with engine.begin() as connection:
15+
result = connection.execute(sqlalchemy.text("select version()"))
16+
for row in result:
17+
assert row[0].startswith('5.7.17')
1718

1819

1920
def test_docker_run_mariadb():
2021
with MySqlContainer("mariadb:10.6.5").maybe_emulate_amd64() as mariadb:
21-
e = sqlalchemy.create_engine(mariadb.get_connection_url())
22-
result = e.execute("select version()")
23-
for row in result:
24-
assert row[0].startswith('10.6.5')
22+
engine = sqlalchemy.create_engine(mariadb.get_connection_url())
23+
with engine.begin() as connection:
24+
result = connection.execute(sqlalchemy.text("select version()"))
25+
for row in result:
26+
assert row[0].startswith('10.6.5')
2527

2628

2729
def test_docker_env_variables():

oracle/testcontainers/oracle/__init__.py

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,8 +13,9 @@ class OracleDbContainer(DbContainer):
1313
>>> from testcontainers.oracle import OracleDbContainer
1414
1515
>>> with OracleDbContainer() as oracle:
16-
... e = sqlalchemy.create_engine(oracle.get_connection_url())
17-
... result = e.execute("select * from V$VERSION")
16+
... engine = sqlalchemy.create_engine(oracle.get_connection_url())
17+
... with engine.begin() as connection:
18+
... result = connection.execute(sqlalchemy.text("select * from V$VERSION"))
1819
"""
1920

2021
def __init__(self, image: str = "wnameless/oracle-xe-11g-r2:latest", **kwargs) -> None:

oracle/tests/test_oracle.py

Lines changed: 9 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -5,12 +5,13 @@
55

66
@pytest.mark.skip(reason="needs oracle client libraries unavailable on Travis")
77
def test_docker_run_oracle():
8+
versions = {'Oracle Database 11g Express Edition Release 11.2.0.2.0 - 64bit Production',
9+
'PL/SQL Release 11.2.0.2.0 - Production',
10+
'CORE\t11.2.0.2.0\tProduction',
11+
'TNS for Linux: Version 11.2.0.2.0 - Production',
12+
'NLSRTL Version 11.2.0.2.0 - Production'}
813
with OracleDbContainer() as oracledb:
9-
e = sqlalchemy.create_engine(oracledb.get_connection_url())
10-
result = e.execute("select * from V$VERSION")
11-
versions = {'Oracle Database 11g Express Edition Release 11.2.0.2.0 - 64bit Production',
12-
'PL/SQL Release 11.2.0.2.0 - Production',
13-
'CORE\t11.2.0.2.0\tProduction',
14-
'TNS for Linux: Version 11.2.0.2.0 - Production',
15-
'NLSRTL Version 11.2.0.2.0 - Production'}
16-
assert {row[0] for row in result} == versions
14+
engine = sqlalchemy.create_engine(oracledb.get_connection_url())
15+
with engine.begin() as connection:
16+
result = connection.execute(sqlalchemy.text("select * from V$VERSION"))
17+
assert {row[0] for row in result} == versions

postgres/testcontainers/postgres/__init__.py

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -31,9 +31,10 @@ class PostgresContainer(DbContainer):
3131
3232
>>> postgres_container = PostgresContainer("postgres:9.5")
3333
>>> with postgres_container as postgres:
34-
... e = sqlalchemy.create_engine(postgres.get_connection_url())
35-
... result = e.execute("select version()")
36-
... version, = result.fetchone()
34+
... engine = sqlalchemy.create_engine(postgres.get_connection_url())
35+
... with engine.begin() as connection:
36+
... result = connection.execute(sqlalchemy.text("select version()"))
37+
... version, = result.fetchone()
3738
>>> version
3839
'PostgreSQL 9.5...'
3940
"""

postgres/tests/test_postgres.py

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -5,14 +5,16 @@
55
def test_docker_run_postgres():
66
postgres_container = PostgresContainer("postgres:9.5")
77
with postgres_container as postgres:
8-
e = sqlalchemy.create_engine(postgres.get_connection_url())
9-
result = e.execute("select version()")
10-
for row in result:
11-
assert row[0].lower().startswith("postgresql 9.5")
8+
engine = sqlalchemy.create_engine(postgres.get_connection_url())
9+
with engine.begin() as connection:
10+
result = connection.execute(sqlalchemy.text("select version()"))
11+
for row in result:
12+
assert row[0].lower().startswith("postgresql 9.5")
1213

1314

1415
def test_docker_run_postgres_with_driver_pg8000():
1516
postgres_container = PostgresContainer("postgres:9.5", driver="pg8000")
1617
with postgres_container as postgres:
17-
e = sqlalchemy.create_engine(postgres.get_connection_url())
18-
e.execute("select 1=1")
18+
engine = sqlalchemy.create_engine(postgres.get_connection_url())
19+
with engine.begin() as connection:
20+
connection.execute(sqlalchemy.text("select 1=1"))

0 commit comments

Comments
 (0)