Skip to content

Commit f0278b1

Browse files
committed
fix tests
1 parent dd92175 commit f0278b1

File tree

2 files changed

+3
-7
lines changed

2 files changed

+3
-7
lines changed

modules/mysql/testcontainers/mysql/__init__.py

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -106,11 +106,7 @@ def _connect(self) -> None:
106106
)
107107

108108
def get_connection_url(self) -> str:
109-
dialect = "mysql"
110-
111-
if self.dialect is not None:
112-
dialect = f"mysql+{self.dialect}"
113-
109+
dialect = "mysql" if self.dialect is None else f"mysql+{self.dialect}"
114110
return super()._create_connection_url(
115111
dialect=dialect, username=self.username, password=self.password, dbname=self.dbname, port=self.port
116112
)

modules/mysql/tests/test_mysql.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ def test_docker_run_mysql():
2727

2828
@pytest.mark.skipif(is_arm(), reason="mysql container not available for ARM")
2929
def test_docker_run_legacy_mysql():
30-
config = MySqlContainer("mysql:5.7.44")
30+
config = MySqlContainer("mysql:5.7.44", dialect="pymysql")
3131
with config as mysql:
3232
engine = sqlalchemy.create_engine(mysql.get_connection_url())
3333
with engine.begin() as connection:
@@ -50,7 +50,7 @@ def test_docker_run_mysql_8_seed():
5050

5151
@pytest.mark.parametrize("version", ["11.3.2", "10.11.7"])
5252
def test_docker_run_mariadb(version: str):
53-
with MySqlContainer(f"mariadb:{version}") as mariadb:
53+
with MySqlContainer(f"mariadb:{version}", dialect="pymysql") as mariadb:
5454
engine = sqlalchemy.create_engine(mariadb.get_connection_url())
5555
with engine.begin() as connection:
5656
result = connection.execute(sqlalchemy.text("select version()"))

0 commit comments

Comments
 (0)