Skip to content

Commit e78a74f

Browse files
chore: use re-exported bollard from testcontainers to avoid collisions (#394)
1 parent 34f2219 commit e78a74f

File tree

2 files changed

+16
-6
lines changed

2 files changed

+16
-6
lines changed

Cargo.toml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -91,7 +91,6 @@ aws-sdk-dynamodb = "1.2.0"
9191
aws-sdk-s3 = "1.2.0"
9292
aws-sdk-sqs = "1.2.0"
9393
aws-types = "1.0.1"
94-
bollard = "0.19.1"
9594
databend-driver = "0.27.3"
9695
futures = "0.3"
9796
lapin = "3.0.0"

src/cncf_distribution/mod.rs

Lines changed: 16 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -50,11 +50,17 @@ impl Image for CncfDistribution {
5050

5151
#[cfg(test)]
5252
mod tests {
53-
use bollard::query_parameters::{
54-
CreateImageOptionsBuilder, PushImageOptionsBuilder, RemoveImageOptions,
55-
};
5653
use futures::StreamExt;
57-
use testcontainers::{runners::AsyncBuilder, GenericBuildableImage, Image};
54+
use testcontainers::{
55+
bollard::{
56+
query_parameters::{
57+
CreateImageOptionsBuilder, PushImageOptionsBuilder, RemoveImageOptions,
58+
},
59+
Docker,
60+
},
61+
runners::AsyncBuilder,
62+
GenericBuildableImage, Image,
63+
};
5864

5965
use crate::{cncf_distribution, testcontainers::runners::AsyncRunner};
6066

@@ -69,7 +75,7 @@ mod tests {
6975
let distribution_node = cncf_distribution::CncfDistribution::default()
7076
.start()
7177
.await?;
72-
let docker = bollard::Docker::connect_with_local_defaults().unwrap();
78+
let docker = Docker::connect_with_local_defaults().unwrap();
7379

7480
let image_name = &format!(
7581
"localhost:{}/test",
@@ -123,6 +129,11 @@ mod tests {
123129
format!("{}:{}", image.name(), image.tag())
124130
);
125131

132+
// clean-up
133+
docker
134+
.remove_image(image.name(), None::<RemoveImageOptions>, None)
135+
.await?;
136+
126137
Ok(())
127138
}
128139
}

0 commit comments

Comments
 (0)