Cleanup or restart a stopped container that is supposed to be reused

[tisonkun]

See the following context.

However, this can't handle the case where an existing container is stopped. It would then failed with:

called `Result::unwrap()` on an `Err` value: Client(CreateContainer(DockerResponseServerError { status_code: 409, message: "Conflict. The container name \"/postgres\" is already in use by container \"5d2940fb2bd042cf859598932aae34aa5004b19d38797165806282b4ada66157\". You have to remove (or rename) that container to be able to reuse that name." }))
thread 'test_simple_pubsub' panicked at tests/toolkit/src/container.rs:150:10:
called `Result::unwrap()` on an `Err` value: Client(CreateContainer(DockerResponseServerError { status_code: 409, message: "Conflict. The container name \"/postgres\" is already in use by container \"5d2940fb2bd042cf859598932aae34aa5004b19d38797165806282b4ada66157\". You have to remove (or rename) that container to be able to reuse that name." }))

I resolve this issue in my bollard based solution by removing a stopped container with the same name, but not sure how to make it more smoothly in testcontainers.

Anyway, this can be a follow-up to improved:

async fn maybe_remove_container(&self, docker: &Docker, container_name: &str) {
    let options = Some(RemoveContainerOptions {
        v: true,
        force: true,
        link: false,
    });

    // best effort to remove existing container; ignore errors
    let _ = docker.remove_container(container_name, options).await;
}

Originally posted by @tisonkun in #887 (comment)

stopped container

This is common when a lasting test container gets stopped during the dev machine reboot.

Originally posted by @tisonkun in #887 (comment)

[tisonkun]

I'm glad to investigate it but I can't commit the time here. So if any other would dive into this issue, feel free to contribute as well!

[DDtKey]

I believe it's closed by #896

It's been merged to main and will be released soon

[tisonkun]

Great! Once it releases I can test it in my project then :D

[DDtKey]

Hi!

It's been released

I would appreciate it if you could try it out and let me know if it works for you.

Thanks!

[tisonkun]

@DDtKey it generally works. But I noticed that we have use bollard with its buildkit_providerless which polls in several dependencies:

buildkit_providerless = [
    "chrono",
    "num",
    "rand",
    "tokio/fs",
    "tokio-stream",
    "tokio-util/io",
    "tonic",
    "tower-service",
    "ssl_providerless",
    "bollard-stubs/buildkit",
    "bollard-buildkit-proto",
    "dep:async-stream",
    "dep:bitflags",
]

I tend to avoid dependencies like chrono, tonic, axum, async-stream. Where do we depend on them and whether we can get rid of it or make it opt-in.

[tisonkun]

Besides, on CI, it failed with:

    thread 'common_tests::test_add_drop_column' (17372) panicked at tests/testkit/src/container/mod.rs:22:14:
    called `Result::unwrap()` on an `Err` value: Client(CreateContainer(DockerResponseServerError { status_code: 409, message: "Conflict. The container name \"/test-scopedb-postgres-16-3-bullseye\" is already in use by container \"fd849970de9c59655c7d594fb06d2aacc191f44edea04ab0852cd5f9b2611b78\". You have to remove (or rename) that container to be able to reuse that name." }))
    note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace