Remove satisfy() from stubbing store

I could not for the life of me figure out why app code was being invoked
from a value object. Obviously it's a thing I (tell people to) avoid
doing, but as I dove in I realized that this stupid unit test was also
depending on this dummy implementation of satisfy() working in order
to also pass.

Not only was that unhelpful incidental coverage, it was obnoxious b/c
I needed to delete that implementation to start driving out an actual
satisfy() solution, and I didn't want to stare at this unrelated error.

Author: searls

src/function/generate-fake-function.js

@@ -1,12 +1,12 @@
 import CallLog from '../value/call-log'
 import Call from '../value/call'
-import StubbingRegister from '../value/stubbing-register'
+import satisfy from '../satisfy'
 
 export default function generateFakeFunction (double) {
   const testDouble = function testDouble (...args) {
     const call = new Call(this, args)
     CallLog.instance.log(double, call)
-    return StubbingRegister.instance.satisfy(double, call)
+    return satisfy(double, call)
   }
   testDouble.toString = double.toString.bind(double)
 

src/satisfy/index.js

@@ -1,8 +1,7 @@
 // import _ from '../wrap/lodash'
 
-export default (call, stubbings) => {
+export default function satisfy (double, call) {
   // TODO: dummy impl to drive create feature first
-  return stubbings ? stubbings[0].outcomes[0] : undefined
 
   // 1. find the last matching stubbing (args+conditions match + has values left)
   // 2. six-way switch to execute the correct plan switching on the stubbing's `type`

src/value/stubbing-register.js

@@ -1,7 +1,5 @@
 import Map from 'es6-map'
 
-import satisfy from '../satisfy'
-
 let instance = null
 
 export default class StubbingRegister {
@@ -27,10 +25,6 @@ export default class StubbingRegister {
     }
   }
 
-  satisfy (double, call) {
-    return satisfy(call, this.stubbings.get(double))
-  }
-
   get (double) {
     return this.stubbings.get(double)
   }

test/unit/function/generate-fake-function.test.js

@@ -1,10 +1,14 @@
 import Double from '../../../src/value/double'
+import Call from '../../../src/value/call'
 import CallLog from '../../../src/value/call-log'
-import StubbingRegister from '../../../src/value/stubbing-register'
-import Stubbing from '../../../src/value/stubbing'
-import subject from '../../../src/function/generate-fake-function'
 
+let satisfy, subject
 module.exports = {
+  beforeEach: () => {
+    satisfy = td.replace('../../../src/satisfy').default
+
+    subject = require('../../../src/function/generate-fake-function').default
+  },
   'the fake function itself': {
     'logs calls': () => {
       const double = Double.create()
@@ -18,12 +22,13 @@ module.exports = {
     },
     'registers stubbing': () => {
       const double = Double.create()
-      const stubbing = new Stubbing('return', ['a', 'b'], ['c'])
-      StubbingRegister.instance.add(double, stubbing)
+      const self = {}
+      const call = new Call(self, [42])
+      td.when(satisfy(double, call)).thenReturn('woot')
 
-      const result = subject(double)('a', 'b')
+      const result = subject(double).call(self, 42)
 
-      assert.equal(result, 'c')
+      assert.equal(result, 'woot')
     }
   },
   'sets toString to that of the double': () => {

test/unit/value/stubbing-register.test.js

@@ -1,5 +1,4 @@
 import Double from '../../../src/value/double'
-import Call from '../../../src/value/call'
 import Stubbing from '../../../src/value/stubbing'
 import StubbingRegister from '../../../src/value/stubbing-register'
 
@@ -18,18 +17,5 @@ module.exports = {
     subject.add(double, stubbing)
 
     assert.deepEqual(subject.get(double), [stubbing])
-  },
-  'delegates to another thing to satisfy': () => {
-    const double = Double.create()
-    const stubbing = new Stubbing()
-    const call = new Call()
-    const satisfy = td.replace('../../../src/satisfy').default
-    td.when(satisfy(call, [stubbing])).thenReturn('pants')
-    subject = require('../../../src/value/stubbing-register').default.instance
-    subject.add(double, stubbing)
-
-    const result = subject.satisfy(double, call)
-
-    assert.equal(result, 'pants')
   }
 }