Skip to content

Commit b5cb4c5

Browse files
eps1lonKent C. Dodds
authored andcommitted
fix(perf): improve byRole performance (#381)
Closes #379
1 parent 5783c12 commit b5cb4c5

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

src/queries/role.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -14,9 +14,6 @@ function queryAllByRole(
1414
const matchNormalizer = makeNormalizer({collapseWhitespace, trim, normalizer})
1515

1616
return Array.from(container.querySelectorAll('*'))
17-
.filter(element => {
18-
return hidden === false ? isInaccessible(element) === false : true
19-
})
2017
.filter(node => {
2118
const isRoleSpecifiedExplicitly = node.hasAttribute('role')
2219

@@ -30,6 +27,9 @@ function queryAllByRole(
3027
matcher(implicitRole, node, role, matchNormalizer),
3128
)
3229
})
30+
.filter(element => {
31+
return hidden === false ? isInaccessible(element) === false : true
32+
})
3333
}
3434

3535
const getMultipleError = (c, role) =>

0 commit comments

Comments
 (0)