Skip to content

Commit 906c912

Browse files
committed
Generate tests for all queries combinations for no-await-sync-query rules
1 parent 55d98fd commit 906c912

File tree

1 file changed

+29
-8
lines changed

1 file changed

+29
-8
lines changed

tests/lib/rules/no-await-sync-query.js

Lines changed: 29 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,10 @@
55
// ------------------------------------------------------------------------------
66

77
const rule = require('../../../lib/rules/no-await-sync-query');
8+
const {
9+
SYNC_QUERIES_COMBINATIONS,
10+
ASYNC_QUERIES_COMBINATIONS,
11+
} = require('../../../lib/utils');
812
const RuleTester = require('eslint').RuleTester;
913

1014
// ------------------------------------------------------------------------------
@@ -14,25 +18,42 @@ const RuleTester = require('eslint').RuleTester;
1418
const ruleTester = new RuleTester({ parserOptions: { ecmaVersion: 2018 } });
1519
ruleTester.run('no-await-sync-query', rule, {
1620
valid: [
17-
{
21+
// sync queries without await are valid
22+
...SYNC_QUERIES_COMBINATIONS.map(query => ({
23+
code: `() => {
24+
${query}('foo')
25+
}
26+
`,
27+
})),
28+
29+
// async queries with await operator are valid
30+
...ASYNC_QUERIES_COMBINATIONS.map(query => ({
1831
code: `async () => {
19-
getByText('foo')
32+
await ${query}('foo')
2033
}
2134
`,
22-
},
35+
})),
36+
37+
// async queries with then method are valid
38+
...ASYNC_QUERIES_COMBINATIONS.map(query => ({
39+
code: `() => {
40+
${query}('foo').then(() => {});
41+
}
42+
`,
43+
})),
2344
],
2445

25-
invalid: [
26-
{
46+
invalid:
47+
// sync queries with await operator are not valid
48+
SYNC_QUERIES_COMBINATIONS.map(query => ({
2749
code: `async () => {
28-
await getByText('foo')
50+
await ${query}('foo')
2951
}
3052
`,
3153
errors: [
3254
{
3355
messageId: 'noAwaitSyncQuery',
3456
},
3557
],
36-
},
37-
],
58+
})),
3859
});

0 commit comments

Comments
 (0)