Use messageId for errors

Author: Belco90

lib/rules/await-async-query.js

@@ -8,8 +8,6 @@ const VALID_PARENTS = [
 
 const ASYNC_QUERIES_REGEXP = /^find(All)?By(LabelText|PlaceholderText|Text|AltText|Title|DisplayValue|Role|TestId)$/;
 
-const getError = nodeName => `\`${nodeName}\` must have \`await\` operator`;
-
 module.exports = {
   meta: {
     type: 'problem',
@@ -20,6 +18,9 @@ module.exports = {
       recommended: true,
       url: 'TODO',
     },
+    messages: {
+      awaitAsyncQuery: '`{{ name }}` must have `await` operator',
+    },
     fixable: null,
     schema: [],
   },
@@ -39,7 +40,10 @@ module.exports = {
         if (hasError) {
           context.report({
             node,
-            message: getError(node.name),
+            messageId: 'awaitAsyncQuery',
+            data: {
+              name: node.name,
+            },
           });
         }
       },

lib/rules/no-await-sync-query.js

@@ -2,8 +2,6 @@
 
 const SYNC_QUERIES_REGEXP = /^(get|query)(All)?By(LabelText|PlaceholderText|Text|AltText|Title|DisplayValue|Role|TestId)$/;
 
-const getError = nodeName => `\`${nodeName}\` does not need \`await\` operator`;
-
 module.exports = {
   meta: {
     type: 'problem',
@@ -13,6 +11,9 @@ module.exports = {
       recommended: true,
       url: 'TODO',
     },
+    messages: {
+      noAwaitSyncQuery: '`{{ name }}` does not need `await` operator',
+    },
     fixable: null,
     schema: [],
   },
@@ -24,7 +25,10 @@ module.exports = {
       ) {
         context.report({
           node,
-          message: getError(node.name),
+          messageId: 'noAwaitSyncQuery',
+          data: {
+            name: node.name,
+          },
         });
       },
     };

tests/lib/rules/await-async-query.js

@@ -68,7 +68,7 @@ ruleTester.run('await-async-query', rule, {
       `,
       errors: [
         {
-          message: '`findByText` must have `await` operator',
+          messageId: 'awaitAsyncQuery',
         },
       ],
     },
@@ -80,7 +80,7 @@ ruleTester.run('await-async-query', rule, {
       `,
       errors: [
         {
-          message: '`findByText` must have `await` operator',
+          messageId: 'awaitAsyncQuery',
         },
       ],
     },
@@ -92,7 +92,7 @@ ruleTester.run('await-async-query', rule, {
       `,
       errors: [
         {
-          message: '`findAllByText` must have `await` operator',
+          messageId: 'awaitAsyncQuery',
         },
       ],
     },

tests/lib/rules/no-await-sync-query.js

@@ -30,7 +30,7 @@ ruleTester.run('no-await-sync-query', rule, {
       `,
       errors: [
         {
-          message: '`getByText` does not need `await` operator',
+          messageId: 'noAwaitSyncQuery',
         },
       ],
     },