Skip to content

fix: support AssignmentExpression in userEvent setup detection #1055

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

y-hsgw
Copy link
Member

@y-hsgw y-hsgw commented Aug 2, 2025

Checks

Changes

  • Add support for detecting userEvent instances assigned via AssignmentExpression.
  • Move userEventInstanceNames into the create function scope to avoid cross-file caching issues.

Context

Copy link

codecov bot commented Aug 2, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.45%. Comparing base (92a6bf5) to head (d3b4fb2).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1055      +/-   ##
==========================================
+ Coverage   96.44%   96.45%   +0.01%     
==========================================
  Files          50       50              
  Lines        2697     2710      +13     
  Branches     1115     1121       +6     
==========================================
+ Hits         2601     2614      +13     
  Misses         96       96              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@y-hsgw y-hsgw linked an issue Aug 3, 2025 that may be closed by this pull request
@Belco90 Belco90 merged commit d428723 into testing-library:main Aug 12, 2025
31 checks passed
Copy link

🎉 This PR is included in version 7.6.6 🎉

The release is available on:

Your semantic-release bot 📦🚀

@y-hsgw y-hsgw deleted the fix/no-node-access-assignment-case branch August 12, 2025 05:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[no-node-access] False positives for no-node-access
2 participants