Skip to content

Commit b8b8492

Browse files
authored
Note about guiding principle on feature request template
1 parent 7921e4a commit b8b8492

File tree

1 file changed

+9
-0
lines changed

1 file changed

+9
-0
lines changed

.github/ISSUE_TEMPLATE/Feature_Request.md

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,15 @@ this free short video tutorial to learn how: http://kcd.im/pull-request
2626
<!--
2727
A clear and concise description of what you want to happen. Add any considered
2828
drawbacks.
29+
30+
Note: if you're proposing a new custom matcher, please keep in mind jest-dom's
31+
guiding principles as stated here https://github.com/testing-library/jest-dom#guiding-principles
32+
33+
In particular, keep this in mind:
34+
35+
> the overall criteria for what is considered a useful custom matcher to add to
36+
> this library, is that doing the equivalent assertion on our own makes the test
37+
> code more verbose, less clear in its intent, and/or harder to read.
2938
-->
3039

3140
### Suggested implementation:

0 commit comments

Comments
 (0)