code cleanup

Author: delabiejochen

src/main/java/com/testingbot/tunnel/Api.java

@@ -84,7 +84,7 @@ public void destroyTunnel() throws Exception {
 
         if (app.getProxy() != null) {
             String[] splitted = app.getProxy().split(":");
-            int port = splitted.length > 1 ? Integer.valueOf(splitted[1]) : 80;
+            int port = splitted.length > 1 ? Integer.parseInt(splitted[1]) : 80;
             if (app.getProxyAuth() != null) {
                 String[] credentials = app.getProxyAuth().split(":");
                 CredentialsProvider credsProvider = new BasicCredentialsProvider();
@@ -117,7 +117,7 @@ private JSONObject _post(String url, List<NameValuePair> postData)  throws Excep
 
             if (app.getProxy() != null) {
                 String[] splitted = app.getProxy().split(":");
-                int port = splitted.length > 1 ? Integer.valueOf(splitted[1]) : 80;
+                int port = splitted.length > 1 ? Integer.parseInt(splitted[1]) : 80;
                 if (app.getProxyAuth() != null) {
                     String[] credentials = app.getProxyAuth().split(":");
                     CredentialsProvider credsProvider = new BasicCredentialsProvider();
@@ -176,7 +176,7 @@ private JSONObject _get(String url) throws Exception {
             HttpClientBuilder builder = HttpClientBuilder.create();
             if (app.getProxy() != null) {
                 String[] splitted = app.getProxy().split(":");
-                int port = splitted.length > 1 ? Integer.valueOf(splitted[1]) : 80;
+                int port = splitted.length > 1 ? Integer.parseInt(splitted[1]) : 80;
                 if (app.getProxyAuth() != null) {
                     String[] credentials = app.getProxyAuth().split(":");
                     CredentialsProvider credsProvider = new BasicCredentialsProvider();

src/main/java/com/testingbot/tunnel/App.java

@@ -38,7 +38,7 @@ public class App {
     private SSHTunnel tunnel;
     private String tunnelIdentifier;
     private String serverIP;
-    private Map<String, String> customHeaders = new HashMap<>();
+    private final Map<String, String> customHeaders = new HashMap<>();
     private int hubPort = 4444;
     private int tunnelID = 0;
     private int jettyPort = 0;
@@ -388,7 +388,7 @@ public void boot() throws Exception {
             api.setTunnelID(tunnelID);
         }
 
-        if (Float.parseFloat(tunnelData.getString("version")) > App.VERSION) {
+        if (Float.valueOf(tunnelData.getString("version")) > App.VERSION) {
             System.err.println("A new version (" + tunnelData.getString("version") + ") is available for download at https://testingbot.com\nYou have version " + App.VERSION);
         }
 

src/main/java/ssh/CustomConnectionMonitor.java

@@ -23,6 +23,7 @@ public CustomConnectionMonitor(SSHTunnel tunnel, App app) {
         this.app = app;
     }
 
+    @Override
     public void connectionLost(Throwable reason) {
         if (tunnel.isShuttingDown() == true) {
             return;
@@ -41,6 +42,7 @@ public void connectionLost(Throwable reason) {
 
     class PollTask extends TimerTask {
         private int retryAttempts = 0;
+        @Override
         public void run() {
             try {
                 Logger.getLogger(CustomConnectionMonitor.class.getName()).log(Level.INFO, "Trying to re-establish SSH Connection");

src/main/java/ssh/SSHTunnel.java

@@ -100,6 +100,7 @@ public boolean isAuthenticated() {
     }
 
     class PollTask extends TimerTask {
+        @Override
         public void run() {
             try {
                 // keep-alive attempt

src/main/java/ssh/TunnelPoller.java

@@ -16,7 +16,6 @@ public class TunnelPoller {
     private final App app;
     private final Timer timer;
     private final String tunnelID;
-    private int pollerCount = 0;
 
     public TunnelPoller(App app, String tunnelID) {
         this.app = app;