code cleanup

Author: jochen-testingbot

src/main/java/com/testingbot/tunnel/App.java

@@ -452,7 +452,7 @@ private void startProxies() {
 
         if (!this.noProxy) {
             this.httpProxy = new HttpProxy(this);
-            if (this.getProxy() == null && this.httpProxy.testProxy() == false) {
+            if (this.getProxy() == null && !this.httpProxy.testProxy()) {
                 Logger.getLogger(App.class.getName()).log(Level.INFO, "! Tunnel might not work properly, test failed");
             }
         }
@@ -509,7 +509,7 @@ public void setFreeJettyPort() {
             port = serverSocket.getLocalPort();
             serverSocket.close();
             setJettyPort(port);
-        } catch (IOException ex) {
+        } catch (IOException ignored) {
         }
     }
 
@@ -685,7 +685,7 @@ public int getSSHPort() {
                 port = serverSocket.getLocalPort();
                 serverSocket.close();
                 sshPort = port;
-            } catch (IOException ex) {
+            } catch (IOException ignored) {
             }
         }
         return sshPort;

src/main/java/com/testingbot/tunnel/Statistics.java

@@ -12,13 +12,6 @@ public static long getNumberOfRequests() {
         return numberOfRequests;
     }
 
-    /**
-     * @param aNumberOfRequests the numberOfRequests to set
-     */
-    public static void setNumberOfRequests(long aNumberOfRequests) {
-        numberOfRequests = aNumberOfRequests;
-    }
-
     /**
      * @return the startTime
      */
@@ -40,13 +33,6 @@ public static long getBytesTransferred() {
         return bytesTransferred;
     }
 
-    /**
-     * @param aBytesTransferred the bytesTransferred to set
-     */
-    public static void setBytesTransferred(long aBytesTransferred) {
-        bytesTransferred = aBytesTransferred;
-    }
-
     public static void addBytesTransferred(long aBytesTransferred) {
         bytesTransferred += aBytesTransferred;
     }

src/main/java/com/testingbot/tunnel/proxy/CustomAuthentication.java

@@ -16,33 +16,34 @@ public class TunnelPoller {
     private final App app;
     private final Timer timer;
     private final String tunnelID;
-    
+
     public TunnelPoller(App app, String tunnelID) {
         this.app = app;
         this.tunnelID = tunnelID;
         timer = new Timer();
         timer.schedule(new PollTask(), 5000, 5000);
     }
-    
+
     public void cancel() {
         timer.cancel();
     }
-    
+
     class PollTask extends TimerTask {
         int counter = 0;
-        
+
         @Override
         public void run() {
             Api api = app.getApi();
             JSONObject response;
             try {
                 response = api.pollTunnel(tunnelID);
-                
+
                 if (this.counter > 80) {
                     Logger.getLogger(TunnelPoller.class.getName()).log(Level.SEVERE, "Unable to create tunnel, waited for 400 seconds. Please try again or check https://status.testingbot.com");
                     timer.cancel();
+                    return;
                 }
-            
+
                 if (response.getString("state").equals("READY")) {
                    timer.cancel();
                    app.tunnelReady(response);