Doctor: use exit code to indicate success/failure

Author: jochen-testingbot

src/main/java/com/testingbot/tunnel/App.java

@@ -168,6 +168,16 @@ public static void main(String... args) throws Exception {
             String clientKey = null;
             String clientSecret = null;
 
+            if (commandLine.hasOption("se-port")) {
+                app.seleniumPort = Integer.parseInt(commandLine.getOptionValue("se-port"));
+            }
+
+            if (commandLine.hasOption("localproxy")) {
+                app.setJettyPort(Integer.parseInt(commandLine.getOptionValue("localproxy")));
+            } else {
+                app.setFreeJettyPort();
+            }
+
             if (commandLine.hasOption("doctor")) {
                 app.doctor();
                 return;
@@ -256,12 +266,6 @@ public static void main(String... args) throws Exception {
                 app.pac = commandLine.getOptionValue("pac");
             }
 
-            if (commandLine.hasOption("localproxy")) {
-                app.setJettyPort(Integer.parseInt(commandLine.getOptionValue("localproxy")));
-            } else {
-                app.setFreeJettyPort();
-            }
-
             if (commandLine.hasOption("readyfile")) {
                 app.readyFile = commandLine.getOptionValue("readyfile").trim();
             }
@@ -292,10 +296,6 @@ public static void main(String... args) throws Exception {
                 LocalWebServer local = new LocalWebServer(commandLine.getOptionValue("web"));
             }
 
-            if (commandLine.hasOption("se-port")) {
-                app.seleniumPort = Integer.parseInt(commandLine.getOptionValue("se-port"));
-            }
-
             app.init();
             app.boot();
         } catch (ParseException parseException) {
@@ -476,6 +476,9 @@ private void startProxies() {
 
     public void doctor() {
         Doctor doctor = new Doctor(this);
+        if (doctor.hasFailures()) {
+            System.exit(1);
+        }
     }
 
     public HttpProxy getHttpProxy() {

src/main/java/com/testingbot/tunnel/Doctor.java

@@ -32,8 +32,9 @@
  * @author testingbot
  */
 public final class Doctor {
-
     private final App app;
+    private boolean hasFailures = false;
+
     public Doctor(App app) {
         this.app = app;
         app.setFreeJettyPort();
@@ -45,18 +46,24 @@ public Doctor(App app) {
             uris.add(new URI("https://www.google.com/"));
         } catch (URISyntaxException e) {
             Logger.getLogger(Doctor.class.getName()).log(Level.SEVERE, e.getMessage());
+            hasFailures = true;
         }
 
         performChecks(uris);
     }
 
+    public boolean hasFailures() {
+        return hasFailures;
+    }
+
     public void performChecks(ArrayList<URI> uris) {
         try {
             for (URI uri : uris) {
                 performCheck(uri);
             }
         } catch (UnknownHostException e) {
             Logger.getLogger(Doctor.class.getName()).log(Level.SEVERE, e.getMessage());
+            hasFailures = true;
         }
 
         checkOpenPorts();
@@ -67,13 +74,15 @@ public void checkOpenPorts() {
         boolean canOpenJetty = checkPortOpen(app.getJettyPort());
         if (!canOpenJetty) {
             Logger.getLogger(Doctor.class.getName()).log(Level.SEVERE, "Cannot open proxy port {0}.\nDoes this process have the correct permissions?", Integer.toString(app.getJettyPort()));
+            hasFailures = true;
         } else {
             Logger.getLogger(Doctor.class.getName()).log(Level.INFO, "OK - Proxy port {0} can be opened", Integer.toString(app.getJettyPort()));
         }
 
         boolean canOpenSEPort = checkPortOpen(app.getSeleniumPort());
         if (!canOpenSEPort) {
             Logger.getLogger(Doctor.class.getName()).log(Level.SEVERE, "Cannot open Selenium port {0}.\nPerhaps another process is using this port? Or this process does not have the correct permission?", Integer.toString(app.getSeleniumPort()));
+            hasFailures = true;
         } else {
             Logger.getLogger(Doctor.class.getName()).log(Level.INFO, "OK - Selenium port {0} can be opened", Integer.toString(app.getSeleniumPort()));
         }
@@ -96,6 +105,7 @@ public void performCheck(final URI uri) throws UnknownHostException {
             Logger.getLogger(Doctor.class.getName()).log(Level.INFO, "OK - URL {0} can be reached.", uri.toString());
         } else {
             Logger.getLogger(Doctor.class.getName()).log(Level.SEVERE, "URL {0} can not be reached.", uri.toString());
+            hasFailures = true;
         }
     }