minor code cleanup

Author: delabiejochen

src/commands/run.ts

@@ -91,6 +91,15 @@ export default class RunProject {
 		this.exitHandler();
 	}
 
+	public onReady(): void {
+		if (this.config && this.config.run_settings.realTimeLogs) {
+			const realTime = io.connect('https://hub.testingbot.com:3031');
+			realTime.emit('join', `cypress_${this.projectId}`);
+			realTime.on('cypress_data', this.realTimeMessage.bind(this));
+			realTime.on('cypress_error', this.realTimeError.bind(this));
+		}
+	}
+
 	private registerCloseHandlers(): void {
 		//do something when app is closing
 		process.on('exit', this.exitHandler.bind(this, { cleanup: true }));
@@ -161,7 +170,7 @@ export default class RunProject {
 
 		this.archiver = new Archiver(config);
 		this.uploader = new Uploader(config);
-		this.poller = new Poller(config);
+		this.poller = new Poller(config, this);
 		this.tunnel = new Tunnel(config);
 
 		let zipFile: string;
@@ -192,13 +201,6 @@ export default class RunProject {
 			this.projectId = response.id;
 			uploadSpinner.succeed('Cypress Project is now running on TestingBot');
 
-			if (config.run_settings.realTimeLogs) {
-				const realTime = io.connect('https://hub.testingbot.com:3031');
-				realTime.emit('join', `cypress_${response.id}`);
-				realTime.on('cypress_data', this.realTimeMessage.bind(this));
-				realTime.on('cypress_error', this.realTimeError.bind(this));
-			}
-
 			const poller = await this.poller.check(response.id, uploadSpinner);
 			const testCases = this.parseTestCases(poller.runs);
 			const success = this.parseSuccess(poller.runs);

src/utils/archiver.ts

@@ -14,10 +14,8 @@ export default class Archiver {
 
 	public async start(): Promise<string> {
 		return new Promise((resolve, reject) => {
-			let tempZipFile: string | undefined;
-
 			try {
-				tempZipFile = path.join(os.tmpdir(), 'upload.zip');
+				const tempZipFile = path.join(os.tmpdir(), 'upload.zip');
 				const output = fs.createWriteStream(tempZipFile);
 				const archive = archiver('zip', {
 					zlib: { level: 9 },

src/utils/poller.ts

@@ -2,6 +2,7 @@ import request from 'request';
 import { IConfig } from './config';
 import log from '../log';
 import ora from 'ora';
+import RunProject from '../commands/run';
 
 interface IEnvironment {
 	name: string;
@@ -42,9 +43,11 @@ export default class Poller {
 	private static readonly MAX_RETRIES_WAITING = 60;
 	private static readonly MAX_RETRIES_READY = 900;
 	private initSuccess = false;
+	private runner: RunProject;
 
-	constructor(config: IConfig) {
+	constructor(config: IConfig, runner: RunProject) {
 		this.config = config;
+		this.runner = runner;
 	}
 
 	public async check(id: number, spinner: ora.Ora): Promise<IPollResponse> {
@@ -109,6 +112,8 @@ OS: ${testCase.environment.os}
 View live stream https://testingbot.com/members/tests/${testCase.sessionId}`);
 						}
 					}
+
+					this.runner.onReady()
 				}
 
 				this.retryNumber += 1;