Tweak config and test commands

Ensure that the user is signed in test command. Remove update-date from editable properties, at it is practically alwais overridden. Also fix getting config values bug.

Author: Irene

src/main/java/fi/helsinki/cs/tmc/cli/Application.java

@@ -256,7 +256,6 @@ public boolean runAutoUpdate() {
         long timestamp = now.getTime();
         properties.put(previousUpdateDateKey, Long.toString(timestamp));
         context.saveProperties();
-
         return updated;
     }
 

src/main/java/fi/helsinki/cs/tmc/cli/command/ConfigCommand.java

@@ -90,20 +90,6 @@ public void setter(String value) throws BadValueTypeException {
                 SettingsIo.saveCurrentSettingsToAccountList(context.getSettings());
             }
         });
-        ALLOWED_KEYS.put(updateDateKey, new PropertyFunctions() {
-            @Override
-            public String getter() {
-                return context.getProperties().get(updateDateKey);
-            }
-
-            @Override
-            public void setter(String date) throws BadValueTypeException {
-                if (!date.matches("[0-9]+")) {
-                    throw new BadValueTypeException("Please insert the date as a number");
-                }
-                properties.put(updateDateKey, date);
-            }
-        });
         ALLOWED_KEYS.put(testResultRightKey, new PropertyFunctions() {
             @Override
             public String getter() {
@@ -222,12 +208,13 @@ public void run(CliContext context, CommandLine args) {
                 return;
             }
             String key = args.getOptionValue('g');
-            boolean exists = properties.containsKey(key);
+            boolean exists = ALLOWED_KEYS.containsKey(key);
             if (!exists && !quiet) {
                 io.errorln("The property " + key + " doesn't exist.");
                 return;
             }
-            io.println(exists ? properties.get(key) : "");
+            String value = ALLOWED_KEYS.get(key).getter();
+            io.println(exists ? (value != null ? value : "no value set") : "");
             return;
         } else if (delete) {
             deleteProperties(arguments);

src/main/java/fi/helsinki/cs/tmc/cli/command/DownloadExercisesCommand.java

@@ -49,6 +49,10 @@ public void run(CliContext context, CommandLine args) {
         Io io = context.getIo();
         ctx = context;
 
+        if (!ctx.checkIsLoggedIn(false, true)) {
+            return;
+        }
+
         String[] stringArgs = args.getArgs();
         if (stringArgs.length == 0 || stringArgs.length > 1) {
             io.errorln("You must give a course name as an argument.");
@@ -59,10 +63,6 @@ public void run(CliContext context, CommandLine args) {
         ctx = context;
         showAll = args.hasOption("a");
 
-        if (!ctx.checkIsLoggedIn(false, true)) {
-            return;
-        }
-
         WorkDir workDir = ctx.getWorkDir();
         if (workDir.getConfigFile() != null) {
             io.errorln("Can't download a course inside a course directory.");

src/main/java/fi/helsinki/cs/tmc/cli/command/RunTestsCommand.java

@@ -41,7 +41,9 @@ public void run(CliContext context, CommandLine args) {
             return;
         }
 
-        context.loadUserInformation(true);
+        if (!context.checkIsLoggedIn(false, true)) {
+            return;
+        }
 
         WorkDir workDir = context.getWorkDir();
         for (String path : paths) {